Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify the apt module force documentation #37353

Merged
merged 1 commit into from Mar 15, 2018
Merged

Clarify the apt module force documentation #37353

merged 1 commit into from Mar 15, 2018

Conversation

abadger
Copy link
Contributor

@abadger abadger commented Mar 13, 2018

The force parameter is inherently insecure. Be clearer in the
documentation that this is the case.

Fixes #25242

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

lib/ansible/module/packaging/os/apt.py

ANSIBLE VERSION
devel 2.5

@abadger
Clarify the apt module force documentation
9e2429d 
The force parameter is inherently insecure.  Be clearer in the
documentation that this is the case.

Fixes ansible#25242
@abadger abadger mentioned this pull request Mar 13, 2018
Closed
@ansibot
Copy link
Contributor

ansibot commented Mar 13, 2018

cc @mgwilliams
click here for bot help

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Mar 13, 2018
@ryansb ryansb removed the needs_triage Needs a first human triage before being processed. label Mar 13, 2018
@mkrizek
Copy link
Contributor

mkrizek commented Mar 14, 2018

cc @dharmabumstead

dharmabumstead
dharmabumstead approved these changes Mar 15, 2018
View reviewed changes
Copy link
Contributor

@dharmabumstead dharmabumstead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @abadger

@dharmabumstead dharmabumstead merged commit 5bdc8fe into ansible:devel Mar 15, 2018
abadger added a commit to abadger/ansible that referenced this pull request Mar 15, 2018
@abadger
Clarify the apt module force documentation (ansible#37353)
b7a9b99 
The force parameter is inherently insecure.  Be clearer in the
documentation that this is the case.

Fixes ansible#25242

(cherry picked from commit 5bdc8fe)
nitzmahone pushed a commit that referenced this pull request Mar 15, 2018
@abadger @nitzmahone
Clarify the apt module force documentation (#37353) (#37491)
8d7fe46 
The force parameter is inherently insecure.  Be clearer in the
documentation that this is the case.

Fixes #25242

(cherry picked from commit 5bdc8fe)
@abadger abadger deleted the apt-document-force branch March 19, 2018 15:13
@dagwieers dagwieers added the packaging Packaging category label Mar 3, 2019
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dharmabumstead dharmabumstead dharmabumstead approved these changes

Assignees
No one assigned
Labels
core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. packaging Packaging category support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

APT: silently uses "--allow-untrusted" with aptitude on "safe-upgrade" [security]
6 participants
@abadger @ansibot @mkrizek @dharmabumstead @dagwieers @ryansb