Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bkprt onyx tmp file #37358

Merged
merged 2 commits into from
Mar 15, 2018
Merged

Bkprt onyx tmp file #37358

merged 2 commits into from
Mar 15, 2018

Conversation

abadger
Copy link
Contributor

@abadger abadger commented Mar 13, 2018

SUMMARY

remove creating temp file for debug purposes

Fixes #36955

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

onyx_linkagg.py

ANSIBLE VERSION
stable-2.5
ADDITIONAL INFORMATION

There could be sensitive information in this debugging information so we definitely want this in 2.5.0

samerd and others added 2 commits March 13, 2018 09:27
@samerd @abadger
issue:36955 remove creating temp file for debug
b5cb019 
Signed-off-by: Samer Deeb <samerd@mellanox.com>
(cherry picked from commit 9031533)
@abadger
Add changelog fragment for the onyx tempfile issue
2a90e2b
@mckerrj mckerrj added P2 Priority 2 - Issue Blocks Release affects_2.5 This issue/PR affects Ansible v2.5 labels Mar 13, 2018
@ansibot
Copy link
Contributor

ansibot commented Mar 13, 2018

cc @samerd
click here for bot help

@ansibot ansibot added backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Mar 13, 2018
@abadger abadger added this to To Do in 2.5.x blocker list Mar 15, 2018
@nitzmahone nitzmahone merged commit 36186c3 into ansible:stable-2.5 Mar 15, 2018
@nitzmahone nitzmahone moved this from To Do to In Progress in 2.5.x blocker list Mar 15, 2018
@bcoca bcoca moved this from In Progress to Done in 2.5.x blocker list Mar 16, 2018
@abadger abadger deleted the bkprt-onyx-tmp-file branch March 16, 2018 21:15
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@abadger abadger

@nitzmahone nitzmahone

Labels
affects_2.5 This issue/PR affects Ansible v2.5 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category P2 Priority 2 - Issue Blocks Release support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
No open projects
2.5.x blocker list
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@abadger @ansibot @mckerrj @nitzmahone @samerd