Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backport] stable-2.5 backport of 'Fix ansible_lo being used inside of ansible_facts' #37360

Merged
merged 1 commit into from
Mar 15, 2018
Merged

[backport] stable-2.5 backport of 'Fix ansible_lo being used inside of ansible_facts' #37360

merged 1 commit into from
Mar 15, 2018

Conversation

alikins
Copy link
Contributor

@alikins alikins commented Mar 13, 2018

SUMMARY

Backport of #37317

The logic was keeping ansible_facts['ansible_lo'] instead of fixing it
to be ansible_facts['lo']

(cherry picked from commit 31878ee)

SUMMARY
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/vars/clean.py

ANSIBLE VERSION
ansible 2.5.0rc2 (stable-2.5-ansible-lo-backport-37317 cb47a10d1b) last updated 2018/03/13 12:52:27 (GMT -400)
  config file = None
  configured module search path = [u'/home/adrian/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /home/adrian/src/ansible/lib/ansible
  executable location = /home/adrian/src/ansible/bin/ansible
  python version = 2.7.14 (default, Feb 27 2018, 20:43:24) [GCC 7.3.1 20180130 (Red Hat 7.3.1-2)]
ADDITIONAL INFORMATION

@abadger @alikins
Fix ansible_lo being used inside of ansible_facts
cb47a10 
The logic was keeping ansible_facts['ansible_lo'] instead of fixing it
to be ansible_facts['lo']

(cherry picked from commit 31878ee)
@alikins alikins added backport This PR does not target the devel branch. affects_2.5 This issue/PR affects Ansible v2.5 labels Mar 13, 2018
@alikins alikins added this to To Do in 2.5.x blocker list via automation Mar 13, 2018
@alikins alikins changed the title Fix ansible_lo being used inside of ansible_facts [backport] stable-2.5 backport of 'Fix ansible_lo being used inside of ansible_facts' Mar 13, 2018
@alikins alikins requested a review from nitzmahone March 13, 2018 16:57
@alikins
Copy link
Contributor Author

alikins commented Mar 13, 2018

pinging @nitzmahone

@alikins alikins added the P2 Priority 2 - Issue Blocks Release label Mar 13, 2018
@ansibot ansibot added bug This issue/PR relates to a bug. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Mar 13, 2018
@nitzmahone nitzmahone merged commit 9ff46ca into ansible:stable-2.5 Mar 15, 2018
@nitzmahone nitzmahone moved this from To Do to 2.5.1 Holding in 2.5.x blocker list Mar 15, 2018
@bcoca bcoca moved this from 2.5.1 Holding to Done in 2.5.x blocker list Mar 16, 2018
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nitzmahone nitzmahone nitzmahone approved these changes

Assignees

@nitzmahone nitzmahone

Labels
affects_2.5 This issue/PR affects Ansible v2.5 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. P2 Priority 2 - Issue Blocks Release support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
No open projects
2.5.x blocker list
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alikins @nitzmahone @ansibot @abadger