Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backport] stable-2.5 issue:36955 remove creating temp file for debug #37373

Merged
merged 1 commit into from
Mar 15, 2018
Merged

[backport] stable-2.5 issue:36955 remove creating temp file for debug #37373

merged 1 commit into from
Mar 15, 2018

Conversation

alikins
Copy link
Contributor

@alikins alikins commented Mar 13, 2018

SUMMARY

Backport of #37308

Remove temporary code that was accessing temp directory

Fixes #36955
There was a temporary code used for debugging, that code was accessing /tmp directly.
This code was removed since there is no need for it

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/modules/network/onyx/onyx_linkagg.py

ANSIBLE VERSION
ansible 2.5.0rc2 (stable-2.5-rm-onyx-link-agg-tmp-37308 c89b767847) last updated 2018/03/13 12:45:20 (GMT -400)
  config file = None
  configured module search path = [u'/home/adrian/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /home/adrian/src/ansible/lib/ansible
  executable location = /home/adrian/src/ansible/bin/ansible
  python version = 2.7.14 (default, Feb 27 2018, 20:43:24) [GCC 7.3.1 20180130 (Red Hat 7.3.1-2)]

@samerd @alikins
issue:36955 remove creating temp file for debug
c89b767 
Signed-off-by: Samer Deeb <samerd@mellanox.com>
(cherry picked from commit 9031533)
@alikins alikins added backport This PR does not target the devel branch. affects_2.5 This issue/PR affects Ansible v2.5 labels Mar 13, 2018
@alikins alikins requested a review from nitzmahone March 13, 2018 21:09
@alikins alikins changed the title issue:36955 remove creating temp file for debug [backport] stable-2.5 issue:36955 remove creating temp file for debug Mar 13, 2018
@alikins alikins added this to To Do in 2.5.x blocker list via automation Mar 13, 2018
@ansibot
Copy link
Contributor

ansibot commented Mar 13, 2018

cc @samerd
click here for bot help

@ansibot ansibot added bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. networking Network category support:community This issue/PR relates to code supported by the Ansible community. labels Mar 13, 2018
@nitzmahone nitzmahone merged commit c474014 into ansible:stable-2.5 Mar 15, 2018
@nitzmahone nitzmahone moved this from To Do to In Progress in 2.5.x blocker list Mar 15, 2018
@bcoca bcoca moved this from In Progress to Done in 2.5.x blocker list Mar 16, 2018
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nitzmahone nitzmahone Awaiting requested review from nitzmahone

Assignees

@nitzmahone nitzmahone

Labels
affects_2.5 This issue/PR affects Ansible v2.5 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. networking Network category support:community This issue/PR relates to code supported by the Ansible community.
Projects
No open projects
2.5.x blocker list
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alikins @ansibot @nitzmahone @samerd