Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sub-interface support for nxos module #37392

Merged
merged 3 commits into from
Apr 25, 2018
Merged

sub-interface support for nxos module #37392

merged 3 commits into from
Apr 25, 2018

Conversation

trishnaguha
Copy link
Member

@trishnaguha trishnaguha commented Mar 14, 2018 •
edited

SUMMARY

fixes #29164

  • Support sub-interface like Ethernet1/6.20
  • Don't send no switchport by default in nxos_l3_interface. User should do make routed interface (mode: layer3) on his/her own before using nxos_l3_interface.
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

modules/network/nxos/{nxos_interface,nxos_l3_interface}.py
test/integration/targets/nxos_l3_interface/tests/{cli,nxapi}/sanity.yaml
test/integration/targets/nxos_interface/tests/common/sub_int.yaml

ANSIBLE VERSION
devel

@ansibot
Copy link
Contributor

ansibot commented Mar 14, 2018

cc @jedelman8 @kedarX @mikewiebe @privateip @rahushen @rcarrillocruz
click here for bot help

@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category nxos Cisco NXOS community support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests. labels Mar 14, 2018
@trishnaguha trishnaguha removed the needs_triage Needs a first human triage before being processed. label Mar 14, 2018
@trishnaguha trishnaguha changed the title [WIP] sub-interface support for nxos module sub-interface support for nxos module Mar 14, 2018
@trishnaguha trishnaguha removed the WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. label Mar 14, 2018
@ansibot ansibot added the core_review In order to be merged, this PR must follow the core review workflow. label Mar 14, 2018
@trishnaguha trishnaguha added this to the 2.6.0 milestone Mar 15, 2018
@trishnaguha
nxos sub-interface support
e7e6365 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
@trishnaguha
update l3_interface test
ef9e258 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Mar 23, 2018
@trishnaguha trishnaguha added this to In Review in Networking Apr 24, 2018
Qalthos
Qalthos approved these changes Apr 24, 2018
View reviewed changes
Copy link
Contributor

@Qalthos Qalthos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd make the substitution for simplicity, but looks reasonable otherwise

lib/ansible/modules/network/nxos/nxos_interface.py
@@ -316,7 +316,7 @@ def normalize_interface(name):
def _get_number(name):
digits = ''
for char in name:
if char.isdigit() or char == '/':
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or char in '/.'

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough!

@trishnaguha trishnaguha moved this from In Review to Done in Networking Apr 25, 2018
@trishnaguha
Add integration test
68d80d7 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 25, 2018
@trishnaguha trishnaguha merged commit 6db3f52 into ansible:devel Apr 25, 2018
@trishnaguha trishnaguha deleted the sub_interface_nxos branch April 25, 2018 07:16
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 12, 2018
@trishnaguha
sub-interface support for nxos module (ansible#37392)
b0a75e4 
* nxos sub-interface support

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* update l3_interface test

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Add integration test

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 14, 2018
@trishnaguha
sub-interface support for nxos module (ansible#37392)
6a5febf 
* nxos sub-interface support

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* update l3_interface test

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Add integration test

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 14, 2018
@trishnaguha
sub-interface support for nxos module (ansible#37392)
8e597be 
* nxos sub-interface support

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* update l3_interface test

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Add integration test

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 15, 2018
@trishnaguha
sub-interface support for nxos module (ansible#37392)
0b6fb9c 
* nxos sub-interface support

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* update l3_interface test

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Add integration test

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 15, 2018
@trishnaguha
sub-interface support for nxos module (ansible#37392)
95d28e0 
* nxos sub-interface support

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* update l3_interface test

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Add integration test

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
@trishnaguha @ilicmilan
sub-interface support for nxos module (ansible#37392)
febbe8b 
* nxos sub-interface support

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* update l3_interface test

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Add integration test

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
@dagwieers dagwieers added the cisco Cisco technologies label Feb 23, 2019
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Qalthos Qalthos Qalthos approved these changes

Assignees
No one assigned
Labels
cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. networking Network category nxos Cisco NXOS community support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests.
Projects
No open projects
Networking
  
Done
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.

Cannot create subinterfaces using nxos_interface
4 participants
@trishnaguha @ansibot @Qalthos @dagwieers