Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up Grafana docs a bit #37516

Merged
merged 2 commits into from Mar 17, 2018
Merged

Clean up Grafana docs a bit #37516

merged 2 commits into from Mar 17, 2018

Conversation

dagwieers
Copy link
Contributor

SUMMARY

But more is needed, default values, missing choices, proper descriptions, actual sentences :-)

This is related to the new module docs, you can see how it currently looks at:

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
COMPONENT NAME

grafana docs

ANSIBLE VERSION

v2.5

@dagwieers
Clean up Grafana docs a bit
9a10afd 
But more is needed, default values, missing choices, proper
descriptions, actual sentences :-)
@dagwieers dagwieers added the docs This issue/PR relates to or includes documentation. label Mar 16, 2018
@dagwieers dagwieers added this to the 2.5.0 milestone Mar 16, 2018
@dagwieers dagwieers added this to To Do in 2.5.x blocker list via automation Mar 16, 2018
@ansibot
Copy link
Contributor

ansibot commented Mar 16, 2018

cc @tsalle
click here for bot help

@ansibot ansibot added bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. labels Mar 16, 2018
@abadger
Copy link
Contributor

abadger commented Mar 16, 2018 via email

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Mar 16, 2018
@ansibot
Copy link
Contributor

ansibot commented Mar 16, 2018

cc @mattclay
click here for bot help

@ansibot ansibot added support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 16, 2018
@ansible ansible deleted a comment from ansibot Mar 17, 2018
@dagwieers dagwieers merged commit 51662ac into ansible:devel Mar 17, 2018
@seuf seuf mentioned this pull request Mar 19, 2018
Merged
@nitzmahone nitzmahone moved this from To Do to Done in 2.5.x blocker list Apr 18, 2018
nitzmahone pushed a commit that referenced this pull request Apr 18, 2018
@dagwieers @nitzmahone
Clean up Grafana docs a bit (#37516)
3d0c000 
* Clean up Grafana docs a bit

But more is needed, default values, missing choices, proper
descriptions, actual sentences :-)

* Remove validate-modules entries

(cherry picked from commit 51662ac)
@dagwieers dagwieers added the grafana Grafana community label Feb 7, 2019
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gundalow gundalow gundalow approved these changes

@abadger abadger Awaiting requested review from abadger

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. grafana Grafana community module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
No open projects
2.5.x blocker list
  
Done
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dagwieers @ansibot @abadger @gundalow