Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changes default WAPI version to 2.1 #37578

Merged
merged 1 commit into from
Mar 28, 2018
Merged

changes default WAPI version to 2.1 #37578

merged 1 commit into from
Mar 28, 2018

Conversation

brampling
Copy link
Contributor

SUMMARY

Changes the default WAPI version from 1.4 to 2.1. WAPI version 2.1 is from NIOS 7.1 which is the oldest NIOS version currently in extended support. There is no reason to use 1.4 and we will note that NIOS 7.1 is the minimum required version after this change.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

module_utils/net_tools/nios/api.py

ANSIBLE VERSION
ansible 2.6.0 (wapi-version cf548489fd) last updated 2018/03/18 11:17:22 (GMT -700)
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/home/brampling/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /home/brampling/Dropbox/src/ansibledev/ansible/lib/ansible
  executable location = /home/brampling/Dropbox/src/ansibledev/ansible/bin/ansible
  python version = 2.7.12 (default, Dec  4 2017, 14:50:18) [GCC 5.4.0 20160609]
ADDITIONAL INFORMATION

N/A

@ansibot
Copy link
Contributor

ansibot commented Mar 18, 2018

cc @Qalthos @ganeshrn @gdpak @gundalow @kedarX @privateip @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. net_tools Net-tools category networking Network category new_contributor This PR is the first contribution by a new community member. support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 18, 2018
@brampling brampling mentioned this pull request Mar 22, 2018
Closed
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Mar 22, 2018
@brampling
Copy link
Contributor Author

This change to the default was made in infoblox-client this morning: infobloxopen/infoblox-client#189

It still needs to be updated here too.

@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Mar 27, 2018
@gundalow gundalow merged commit e5d4493 into ansible:devel Mar 28, 2018
@gundalow
Copy link
Contributor

Merged into devel for release in Ansible 2.6.0

Not backporting as this is a feature change

@brampling brampling deleted the wapi-version branch March 28, 2018 17:31
ryancurrah pushed a commit to ryancurrah/ansible that referenced this pull request Apr 4, 2018
@brampling @ryancurrah
changes default WAPI version to 2.1 (ansible#37578)
43e7d1c
@gundalow gundalow added the infoblox Infoblox NIOS label Apr 25, 2018
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
feature This issue/PR relates to a feature request. infoblox Infoblox NIOS net_tools Net-tools category networking Network category new_contributor This PR is the first contribution by a new community member. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@brampling @ansibot @gundalow @samdoran