Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apt: allow for integration tests using fake repo #37639

Merged
merged 4 commits into from Mar 22, 2018
Merged

apt: allow for integration tests using fake repo #37639

merged 4 commits into from Mar 22, 2018

Conversation

mkrizek
Copy link
Contributor

@mkrizek mkrizek commented Mar 20, 2018

SUMMARY

Just like we have with yum https://github.com/ansible/ansible/tree/devel/test/integration/targets/setup_rpm_repo

ISSUE TYPE
  • Test Pull Request
COMPONENT NAME

apt
tests

ANSIBLE VERSION
devel
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Mar 20, 2018

cc @mgwilliams
click here for bot help

@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Mar 20, 2018
@mkrizek mkrizek changed the title [WIP] apt: allow for integration tests using fake repo apt: allow for integration tests using fake repo Mar 20, 2018
@mkrizek mkrizek removed the WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. label Mar 20, 2018
@mkrizek mkrizek requested a review from mattclay March 20, 2018 11:33
@mkrizek mkrizek added this to READY TO REVIEW in CEM Mar 20, 2018
@webknjaz webknjaz removed the needs_triage Needs a first human triage before being processed. label Mar 20, 2018
mattclay
mattclay requested changes Mar 22, 2018
View reviewed changes
test/integration/targets/setup_deb_repo/tasks/main.yml
chdir: "{{ repodir }}"

- name: Install the repo
apt_repository:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This repo should be removed when the test ends (success or failure) along with the installed package(s).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review, should be fixed. Also did that in the yum tests - #37770.

@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Mar 22, 2018
@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Mar 22, 2018
@mkrizek mkrizek merged commit 296ad80 into ansible:devel Mar 22, 2018
@mkrizek mkrizek deleted the apt-fake-repo-tests branch March 22, 2018 18:14
@mkrizek mkrizek moved this from READY TO REVIEW to DONE in CEM Mar 22, 2018
@webknjaz webknjaz mentioned this pull request Sep 2, 2018
Merged
@dagwieers dagwieers added the packaging Packaging category label Mar 3, 2019
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattclay mattclay mattclay approved these changes

Assignees
No one assigned
Labels
packaging Packaging category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
No open projects
CEM
DONE
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mkrizek @ansibot @mattclay @dagwieers @webknjaz