Bkprt py3 pull fix #37663
Merged
Bkprt py3 pull fix #37663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix a traceback in ansible-pull on python3 comparing output from subprocess with a text string. * Rename variables that hold byte strings so we are clear that those are not text strings. * Use to_text() to transform variable that's being displayed as it's less fragile than str(). Fixes ansible#36962 (cherry picked from commit b98ad3a)
ansibot
added
affects_2.5
webknjaz
removed
the
needs_triage
ansibot
removed
the
needs_revision
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Ansible-pull --only-if-changed failed on python3 due to comparing a byte string with a text string.
ISSUE TYPE
COMPONENT NAME
lib/ansible/cli/pull.py
ANSIBLE VERSION