Bkprt py3 csvfile #37665
Merged
Bkprt py3 csvfile #37665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix csvfile traceback on Python3 The csvfile lookup uses some custom iterators. These needed to be ported to handle the python3 iterator protocol. In addition, the csvfile module takes an iterator of byte strings in Python2 and an iterator of text strings in Python3 Fixes ansible#36808 (cherry picked from commit 09325b6)
ansibot
added
affects_2.5
webknjaz
removed
the
needs_triage
ansibot
removed
the
needs_revision
nitzmahone
approved these changes
Mar 29, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
csvfile had several bugs wrt running under Python3. Backport the changes from devel to fix those
ISSUE TYPE
COMPONENT NAME
lib/ansible/plugins/lookup/csvfile.py
ANSIBLE VERSION