Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed Azure SecurityRule to use kwargs instead of positional args #37695

Merged
merged 1 commit into from Mar 23, 2018

Conversation

jborean93
Copy link
Contributor

SUMMARY

Changes the positional args when creating a SecurityRule model to kwargs in case the underlying package changes again in the future.

Fixes #37693

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

azure_rm_common

ANSIBLE VERSION
devel

@ansibot
Copy link
Contributor

ansibot commented Mar 21, 2018

@ansibot ansibot added azure bug This issue/PR relates to a bug. cloud needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Mar 21, 2018
@yuwzho
Copy link
Contributor

yuwzho commented Mar 22, 2018

shipit

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Mar 22, 2018
@jborean93 jborean93 merged commit ca225d6 into ansible:devel Mar 23, 2018
@jborean93 jborean93 deleted the azure-sec-rule-args branch March 23, 2018 10:37
jborean93 added a commit to jborean93/ansible that referenced this pull request Mar 23, 2018
@jborean93
Copy link
Contributor Author

Stable-2.5 backport PR is #37823

@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
azure bug This issue/PR relates to a bug. cloud support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure Multiple Values for Argument when creating a SecurityRule
3 participants