Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs for say.py to indicate how to list voices #37737

Merged
merged 3 commits into from Sep 21, 2018
Merged

Add docs for say.py to indicate how to list voices #37737

merged 3 commits into from Sep 21, 2018

Conversation

smolz
Copy link
Contributor

@smolz smolz commented Mar 21, 2018

SUMMARY

Added a line that describes where to find the available voices for the command

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

say.py

ANSIBLE VERSION
ansible 2.5.0rc2
  config file = None
  configured module search path = [u'/Users/smolz/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/smolz/Dropbox/Programming/python-virtualenvs/ansible-2.5.0.0/lib/python2.7/site-packages/ansible
  executable location = /Users/smolz/Dropbox/Programming/python-virtualenvs/ansible-2.5.0.0/bin/ansible
  python version = 2.7.14 (default, Mar  9 2018, 23:57:12) [GCC 4.2.1 Compatible Apple LLVM 9.0.0 (clang-900.0.39.2)]
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Mar 21, 2018

cc @mpdehaan
click here for bot help

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. support:community This issue/PR relates to code supported by the Ansible community. labels Mar 21, 2018
angystardust
angystardust reviewed Mar 21, 2018
View reviewed changes
lib/ansible/modules/notification/say.py Outdated
@@ -23,6 +23,7 @@
notes:
- In 2.5, this module has been renamed from M(osx_say) into M(say).
- If you like this module, you may also be interested in the osx_say callback plugin.
- A list of available voices, with language, can be found by running `say -v ?` on a OSX computer.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can also add: "and espeak --voices on a Linux host."

@ansibot ansibot added the needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. label Mar 21, 2018
smolz
smolz commented Mar 21, 2018
View reviewed changes
Copy link
Contributor Author

@smolz smolz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added linux command as well

sivel
sivel reviewed Mar 21, 2018
View reviewed changes
lib/ansible/modules/notification/say.py Outdated
@@ -23,6 +23,7 @@
notes:
- In 2.5, this module has been renamed from M(osx_say) into M(say).
- If you like this module, you may also be interested in the osx_say callback plugin.
- A list of available voices, with language, can be found by running `say -v ?` on a OSX host and `espeak --voices` on a Linux host.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of backticks, can you wrap with C()?

@sivel sivel changed the title Update say.py Add docs for say.py to indicate how to list voices Mar 21, 2018
smolz
smolz commented Mar 21, 2018
View reviewed changes
Copy link
Contributor Author

@smolz smolz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed backticks to C()

@ansibot ansibot removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. needs_triage Needs a first human triage before being processed. labels Mar 21, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Mar 30, 2018
@ansibot ansibot removed the new_contributor This PR is the first contribution by a new community member. label May 9, 2018
@ansibot ansibot added the affects_2.6 This issue/PR affects Ansible v2.6 label May 25, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team. and removed community_review In order to be merged, this PR must follow the community review workflow. support:community This issue/PR relates to code supported by the Ansible community. labels Sep 14, 2018
@gundalow gundalow merged commit 0677dab into ansible:devel Sep 21, 2018
gundalow pushed a commit to gundalow/ansible that referenced this pull request Sep 21, 2018
@smolz @gundalow
Add docs for say.py to indicate how to list voices (ansible#37737)
9d8e37d 
* Update say.py

* Update say.py

* Update say.py

(cherry picked from commit 0677dab)
@gundalow
Copy link
Contributor

@smolz Thank you for this. I've merged it into devel and created a backport PR for stable-2.7

acozine pushed a commit that referenced this pull request Sep 21, 2018
@gundalow @acozine
Add docs for say.py to indicate how to list voices (#37737) (#45979)
aa703ed 
* Update say.py
(cherry picked from commit 0677dab)
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sivel sivel sivel left review comments

@angystardust angystardust angystardust left review comments

@gundalow gundalow gundalow approved these changes

Assignees
No one assigned
Labels
affects_2.6 This issue/PR affects Ansible v2.6 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@smolz @ansibot @gundalow @sivel @angystardust