Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure_rm_networkinterface: backport no public IP fix #37762

Merged

Conversation

jborean93
Copy link
Contributor

SUMMARY

Backport of #36824 to stable-2.5

Fixes documentation and ip configuration where no public ip is defined.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

azure_rm_networkinterface

ANSIBLE VERSION
2.5

Zim Kalinowski and others added 2 commits March 22, 2018 09:18
…not be created (ansible#36824)

* fixed issue when public ip address should not be created

* adding test for public ip address

* fixed samples

* another fix to sample formatting

* fixed test

* fix test

* fixed test

* another attempt to fix test

* maybe it works now

* still wrong

* improved check per customer request

* removed stupid semicolon

* updated test to match main scenario

* changed ip configurations to list

* another attempt

(cherry picked from commit 89401f1)
@ansibot
Copy link
Contributor

ansibot commented Mar 21, 2018

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 azure backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cloud core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:certified This issue/PR relates to certified code. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Mar 21, 2018
@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label Mar 21, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Mar 30, 2018
@jborean93 jborean93 merged commit 0c88f19 into ansible:stable-2.5 Apr 2, 2018
@jborean93 jborean93 deleted the azure_rm_networkinterface-no-pub branch April 2, 2018 20:32
@nitzmahone nitzmahone moved this from 2.5.1 Holding to Done in 2.5.x blocker list Apr 10, 2018
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.5 This issue/PR affects Ansible v2.5 azure backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cloud core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:certified This issue/PR relates to certified code. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants