Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update role doc examples #37844

Merged
merged 2 commits into from
Apr 5, 2018
Merged

Update role doc examples #37844

merged 2 commits into from
Apr 5, 2018

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Mar 23, 2018 •
edited

SUMMARY
- also fixed issue with overload of 'name'
- attempted to clarify tag inheritance/application

Fixes #37836

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

docs

ANSIBLE VERSION
n/a

@bcoca bcoca changed the title What is in a name Update role doc examples Mar 23, 2018
@bcoca
fix role examples
17277ae 
- also fixed issue with overload of 'name', fixes ansible#37836
- attempted to clarify tag inheritance/application
@ansibot
Copy link
Contributor

ansibot commented Mar 23, 2018

cc @dharmabumstead
click here for bot help

@ansibot ansibot added docs This issue/PR relates to or includes documentation. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Mar 23, 2018
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Mar 23, 2018
@bcoca bcoca mentioned this pull request Mar 23, 2018
Closed
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 2, 2018
dharmabumstead
dharmabumstead approved these changes Apr 5, 2018
View reviewed changes
Copy link
Contributor

@dharmabumstead dharmabumstead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK with a small edit. Thanks @bcoca

@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 5, 2018
@dharmabumstead dharmabumstead merged commit c62551c into ansible:devel Apr 5, 2018
@bcoca bcoca deleted the what_is_in_a_name branch May 1, 2018 14:07
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
@bcoca @ilicmilan
Update role doc examples (ansible#37844)
9a90269 
* fix role examples

- also fixed issue with overload of 'name', fixes ansible#37836
- attempted to clarify tag inheritance/application

* Typo fix
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dharmabumstead dharmabumstead dharmabumstead approved these changes

Assignees
No one assigned
Labels
docs This issue/PR relates to or includes documentation. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'name' is a reserved variable name in Ansible 2.5 and shouldn't be used in examples
3 participants
@bcoca @ansibot @dharmabumstead