Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

win_uri: backport fix custom header override #37889

Merged
merged 2 commits into from
Apr 2, 2018
Merged

win_uri: backport fix custom header override #37889

merged 2 commits into from
Apr 2, 2018

Conversation

jborean93
Copy link
Contributor

SUMMARY

Fix for win_uri that overrode the headers that were already set like Content-Type when using the headers key.

Backport of #37845

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

win_uri

ANSIBLE VERSION
2.5

@jborean93 jborean93 added this to To Do in 2.5.x blocker list via automation Mar 25, 2018
@jborean93 jborean93 moved this from To Do to 2.5.1 Holding in 2.5.x blocker list Mar 25, 2018
@jborean93 jborean93 mentioned this pull request Mar 25, 2018
Merged
@ansibot
Copy link
Contributor

ansibot commented Mar 25, 2018

cc @blakfeld @dagwieers @jhawkesworth @nitzmahone
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. windows Windows community needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Mar 25, 2018
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Mar 26, 2018
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 2, 2018
@jborean93 jborean93 merged commit 886a88a into ansible:stable-2.5 Apr 2, 2018
@jborean93 jborean93 deleted the win_uri-header-backport branch April 2, 2018 22:30
@nitzmahone nitzmahone moved this from 2.5.1 Holding to Done in 2.5.x blocker list Apr 10, 2018
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nitzmahone nitzmahone nitzmahone approved these changes

Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. windows Windows community
Projects
No open projects
2.5.x blocker list
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jborean93 @ansibot @nitzmahone @sivel @aplc0r