Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include_* details in porting_guide_2.5.rst #37927

Merged
merged 1 commit into from
Apr 5, 2018

Conversation

mejo-
Copy link
Contributor

@mejo- mejo- commented Mar 26, 2018

The example regarding include_* is a bit unclear. First it seems like the v2.4 and v2.5 examples are the same. So I attempted to make the relevant change in the examples more obvious.

+label: docsite_pr

SUMMARY
ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME
ANSIBLE VERSION

ADDITIONAL INFORMATION

The example regarding `include_*` is a bit unclear. First it seems like the v2.4 and v2.5 examples are the same. So I attempted to make the relevant change in the examples more obvious.

 label: docsite_pr
@ansibot
Copy link
Contributor

ansibot commented Mar 26, 2018

@ansibot ansibot added docs This issue/PR relates to or includes documentation. feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Mar 26, 2018
@gundalow gundalow added this to To Do in 2.5.x blocker list via automation Mar 26, 2018
@gundalow gundalow changed the title Update porting_guide_2.5.rst include_* details in porting_guide_2.5.rst Mar 26, 2018
@dagwieers dagwieers added the docsite_pr This PR is created from documentation using the "Edit on GitHub" link. label Mar 26, 2018
@ryansb ryansb removed the needs_triage Needs a first human triage before being processed. label Mar 27, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 4, 2018
@dharmabumstead dharmabumstead merged commit 55fd3d6 into ansible:devel Apr 5, 2018
@gundalow gundalow added docsite_pr This PR is created from documentation using the "Edit on GitHub" link. and removed docsite_pr This PR is created from documentation using the "Edit on GitHub" link. labels Apr 9, 2018
nitzmahone pushed a commit that referenced this pull request Apr 18, 2018
The example regarding `include_*` is a bit unclear. First it seems like the v2.4 and v2.5 examples are the same. So I attempted to make the relevant change in the examples more obvious.

 label: docsite_pr
(cherry picked from commit 55fd3d6)
@nitzmahone nitzmahone moved this from To Do to Done in 2.5.x blocker list Apr 18, 2018
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
The example regarding `include_*` is a bit unclear. First it seems like the v2.4 and v2.5 examples are the same. So I attempted to make the relevant change in the examples more obvious.

 label: docsite_pr
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
docs This issue/PR relates to or includes documentation. docsite_pr This PR is created from documentation using the "Edit on GitHub" link. feature This issue/PR relates to a feature request. new_contributor This PR is the first contribution by a new community member. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

6 participants