revises network portion of 2.5 porting guide #37938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acozine
added
networking
ansibot
added
the
support:core
gundalow
reviewed
Mar 26, 2018
| ansible_become_pass=cisco | ||
| ansible_network_os=ios | ||
| ansible_password=cisco | ||
| ansible_user=cisco | ||
|
|
There was a problem hiding this comment.
Worth linking to network docs here again?
| ------------------------------------------------------------------ | ||
|
|
||
| Ansible 2.5 introduces two persistent connection types, ``network_cli`` and ``netconf``. We recommend you use these whenever possible. | ||
| Unless you need a ``local`` connection, update your playbooks to use ``network_cli`` or ``netconf`` and to |
There was a problem hiding this comment.
Maybe clarify that local is needed when using eAPI/NX-API?
| Unless you need a ``local`` connection, update your playbooks to use ``network_cli`` or ``netconf`` and to | ||
| specify your connection variables with standard Ansible connection variables: | ||
|
|
||
| OLD In Ansible 2.4 |
|
|
||
| We recommend setting connection properties in inventory by group. As you update your playbooks and inventory files, you can easily make the change to ``become`` for privilege escalation (on platforms that support it). For more information, see the :ref:`using become with network modules<become-network>` guide and the :ref:`platform documentation<platform_options>`. To update the ``ios_command`` task above, move the connection properties to inventory like this: | ||
|
|
||
| NEW In Ansible 2.5 |
|
|
||
| Top-level connection arguments like ``username``, ``host``, and ``password`` are deprecated and will be removed in version 2.9. | ||
|
|
||
| OLD In Ansible 2.4 |
|
|
||
| NEW In Ansible 2.5 |
ansibot
added
needs_ci
ganeshrn
approved these changes
Mar 27, 2018
trishnaguha
approved these changes
Mar 27, 2018
gundalow
reviewed
Mar 27, 2018
| @@ -199,12 +199,16 @@ Porting custom scripts | |||
|
|
|||
| No notable changes. | |||
|
|
|||
| Networking | |||
| ========== | |||
| Network | |||
There was a problem hiding this comment.
I think somewhere prominent in this section we should link to the network guide.
gundalow
approved these changes
Mar 27, 2018
|
Chatted with Scott today - he says "if it looks good to you I'm fine with it." I'm going to take that as a positive review and merge. |
acozine
pushed a commit
to acozine/ansible
that referenced
this pull request
Mar 27, 2018
* revises network portion of 2.5 porting guide (cherry picked from commit b72960f)
mattclay
pushed a commit
that referenced
this pull request
Mar 28, 2018
* revises network portion of 2.5 porting guide (cherry picked from commit b72960f)
ryancurrah
pushed a commit
to ryancurrah/ansible
that referenced
this pull request
Apr 4, 2018
* revises network portion of 2.5 porting guide
|
In |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adds more detail, including the persistent connection options to the Network section of the 2.5 Porting Guide.
Fixes #36777
ISSUE TYPE
COMPONENT NAME
ANSIBLE VERSION
2.5 and higher