Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix capitalization on os_project_access examples #37965

Merged
merged 1 commit into from
May 26, 2018
Merged

fix capitalization on os_project_access examples #37965

merged 1 commit into from
May 26, 2018

Conversation

dbckz
Copy link
Contributor

@dbckz dbckz commented Mar 26, 2018

SUMMARY

Fix small typo in examples for new openstack module os_project_access.py, where upper case A has been used instead of lower

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

os_project_access.py

ANSIBLE VERSION
ansible 2.5.0
  config file = None
  configured module search path = [u'/Users/buckleyd/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/buckleyd/.virtualenvs/ansible_25/lib/python2.7/site-packages/ansible
  executable location = /Users/buckleyd/.virtualenvs/ansible_25/bin/ansible
  python version = 2.7.10 (default, Oct 23 2015, 19:19:21) [GCC 4.2.1 Compatible Apple LLVM 7.0.0 (clang-700.0.59.5)]

@ansibot
Copy link
Contributor

ansibot commented Mar 26, 2018

cc @dagnello @emonty @ioggstream @j2sol @juliakreger @rcarrillocruz @Shrews @Thingee
click here for bot help

@ansibot ansibot added cloud community_review In order to be merged, this PR must follow the community review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. openstack support:community This issue/PR relates to code supported by the Ansible community. labels Mar 26, 2018
@Akasurde Akasurde removed the needs_triage Needs a first human triage before being processed. label Mar 27, 2018
@ioggstream
Copy link
Contributor

LGTM

ioggstream
ioggstream approved these changes Mar 27, 2018
View reviewed changes
Copy link
Contributor

@ioggstream ioggstream left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's correct!

lib/ansible/modules/cloud/openstack/os_project_access.py
@@ -57,7 +57,7 @@

EXAMPLES = '''
- name: "Enable access to tiny flavor to your tenant."
os_project_Access:
os_project_access:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

lib/ansible/modules/cloud/openstack/os_project_access.py
@@ -66,7 +66,7 @@


- name: "Disable access to the given flavor to project"
os_project_Access:
os_project_access:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 4, 2018
@ansibot
Copy link
Contributor

ansibot commented May 14, 2018

cc @omgjlk
click here for bot help

@ansibot ansibot added the affects_2.6 This issue/PR affects Ansible v2.6 label May 22, 2018
emonty
emonty approved these changes May 26, 2018
View reviewed changes
Copy link
Contributor

@emonty emonty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@emonty emonty merged commit 02cb0fd into ansible:devel May 26, 2018
gothicx pushed a commit to gothicx/ansible that referenced this pull request Jun 9, 2018
@dbckz @gothicx
fix capitalization on os_project_access examples (ansible#37965)
686ea07
jacum pushed a commit to jacum/ansible that referenced this pull request Jun 26, 2018
@dbckz
fix capitalization on os_project_access examples (ansible#37965)
0e6e80d
@ansible ansible locked and limited conversation to collaborators May 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@emonty emonty emonty approved these changes

@ioggstream ioggstream ioggstream approved these changes

Assignees
No one assigned
Labels
affects_2.6 This issue/PR affects Ansible v2.6 cloud community_review In order to be merged, this PR must follow the community review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. openstack stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dbckz @ansibot @ioggstream @emonty @Akasurde