Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve details and events results for ecs_service_facts #37983

Merged
merged 1 commit into from
Apr 2, 2018
Merged

Improve details and events results for ecs_service_facts #37983

merged 1 commit into from
Apr 2, 2018

Conversation

willthames
Copy link
Contributor

SUMMARY
  • Use AnsibleAWSModule to simplify AWS connection
  • Add Exception handling, pagination, retries and backoff
  • Allow events to be switched off
  • Allow details to be obtained without having to specify services
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ecs_service_facts

ANSIBLE VERSION
ansible 2.6.0 (devel 5d90ebb28e) last updated 2018/03/27 09:08:13 (GMT +1000)
  config file = None
  configured module search path = [u'/Users/will/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/will/src/ansible/lib/ansible
  executable location = /Users/will/src/ansible/bin/ansible
  python version = 2.7.14 (default, Mar  9 2018, 23:57:12) [GCC 4.2.1 Compatible Apple LLVM 9.0.0 (clang-900.0.39.2)]

@ansibot
Copy link
Contributor

ansibot commented Mar 27, 2018

cc @Java1Guy @Java1Guy @kaczynskid
click here for bot help

@ansibot ansibot added aws cloud community_review In order to be merged, this PR must follow the community review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. labels Mar 27, 2018
@ansibot
Copy link
Contributor

ansibot commented Mar 27, 2018

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/ecs_service_facts.py:208:13: undefined-variable Undefined variable 'xrange'

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Mar 27, 2018
Improve details and events results for ecs_service_facts
eac63c4 
* Use AnsibleAWSModule to simplify AWS connection
* Add Exception handling, pagination, retries and backoff
* Allow events to be switched off
* Allow details to be obtained without having to specify services
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 27, 2018
@ryansb ryansb removed the needs_triage Needs a first human triage before being processed. label Mar 27, 2018
@ryansb ryansb self-requested a review March 27, 2018 12:28
ryansb
ryansb approved these changes Mar 27, 2018
View reviewed changes
lib/ansible/modules/cloud/amazon/ecs_service_facts.py
# {'failures': [{'arn': 'arn:aws:ecs:us-west-2:777110527155:cluster/bogus', 'reason': 'MISSING'}],
# 'ResponseMetadata': {'HTTPStatusCode': 200, 'RequestId': '0f66c219-1c42-11e5-8a31-47a93a8a98eb'},
# 'clusters': []}
self.ecs = module.client('ecs')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@s-hertel s-hertel merged commit 423b0e0 into ansible:devel Apr 2, 2018
ryancurrah pushed a commit to ryancurrah/ansible that referenced this pull request Apr 4, 2018
@willthames @ryancurrah
Improve details and events results for ecs_service_facts (ansible#37983)
71c052f 
* Use AnsibleAWSModule to simplify AWS connection
* Add Exception handling, pagination, retries and backoff
* Allow events to be switched off
* Allow details to be obtained without having to specify services
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
@willthames @ilicmilan
Improve details and events results for ecs_service_facts (ansible#37983)
963cf52 
* Use AnsibleAWSModule to simplify AWS connection
* Add Exception handling, pagination, retries and backoff
* Allow events to be switched off
* Allow details to be obtained without having to specify services
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryansb ryansb ryansb approved these changes

@s-hertel s-hertel s-hertel approved these changes

Assignees
No one assigned
Labels
aws cloud community_review In order to be merged, this PR must follow the community review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@willthames @ansibot @ryansb @s-hertel