unit tests for ansible.module_utils.urls #38059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
WIP
mattclay
requested changes
Mar 28, 2018
test/runner/lib/cover.py
Outdated
| if args.include: | ||
| options.extend([ | ||
| '--include', | ||
| args.include |
There was a problem hiding this comment.
Style recommendation....
Since this option (and the following one) only take a single argument, it would be easier to read as:
options.extend(['--include', args.include])Keeping the option and the arg together is also more readable with multiple options (doesn't apply in this case):
options.extend([
'--include', args.include,
'--some-other-arg', args.some_other_arg,
])
|
The test |
Done. See #38061 I'll rebase this to remove the commit after the other is merged. |
ansibot
removed
the
ci_verified
|
The test The test |
|
@mattclay ansible-test changes removed from this PR |
ansibot
removed
the
ci_verified
jborean93
removed
the
needs_triage
sivel
force-pushed
the
urls-units
branch
2 times, most recently
from
fcd8836
to
05e9565
Compare
ansibot
added
the
needs_ci
sivel
changed the title
ansibot
removed
the
needs_ci
|
Removing WIP. I'm going with this as is for now. These tests alone cover 52% of ready_for_review |
ansibot
removed
the
WIP
|
The test |
ansibot
added
the
needs_revision
ansibot
removed
the
needs_revision
mattclay
requested changes
Apr 2, 2018
| @@ -0,0 +1,22 @@ | |||
| # -*- coding: utf-8 -*- | |||
There was a problem hiding this comment.
Rename this file to test_RequestWithMethod.py to match the class it is testing and give the test function test_RequestWithMethod a more specific name. Alternatively, move the test into test_urls.py instead.
| @@ -0,0 +1,66 @@ | |||
| # -*- coding: utf-8 -*- | |||
There was a problem hiding this comment.
Rename this file to generic_urlparse.py to match the function being tested.
| from ansible.module_utils.six.moves.urllib.parse import urlparse, urlunparse | ||
|
|
||
|
|
||
| def test_ParseResultDottedDict(): |
There was a problem hiding this comment.
Move this test function into a new test_ParseResultDottedDict.py file to match the class it is testing and give the test function test_ParseResultDottedDict a more specific name. Alternatively, move the test into test_urls.py instead.
ansibot
added
the
needs_revision
|
The test |
ansibot
added
the
needs_revision
ansibot
removed
the
needs_revision
…ror_307 does not cause issues with urllib2 type redirects
|
A few unstable results in CI. Not related. Merging. |
ilicmilan
pushed a commit
to ilicmilan/ansible
that referenced
this pull request
Nov 7, 2018
* Start of tests for ansible.module_utils.urls * Start adding file for generic functions throughout urls * Add tests for maybe_add_ssl_handler * Remove commented out line * Improve coverage of maybe_add_ssl_handler, test basic_auth_header * Start tests for open_url * pep8 and ignore urlopen in test_url_open.py tests * Extend auth tests, add test for validate_certs=False * Finish tests for open_url * Add tests for fetch_url * Add fetch_url tests to replace-urlopen ignore * dummy instead of _ * Add BadStatusLine test * Reorganize/rename tests * Add tests for RedirectHandlerFactory * Add POST test to confirm behavior is to convert to GET * Update tests to handle recent changes to RedirectHandlerFactory * Special test, just to confirm that aliasing http_error_308 to http_error_307 does not cause issues with urllib2 type redirects
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
unit tests for ansible.module_utils.urls
ISSUE TYPE
COMPONENT NAME
tests/units/module_utils/
ANSIBLE VERSION
ADDITIONAL INFORMATION