Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ec2_snapshot_copy: WaitError and ClientError exception handling #38072

Merged
merged 1 commit into from
Apr 3, 2018
Merged

ec2_snapshot_copy: WaitError and ClientError exception handling #38072

merged 1 commit into from
Apr 3, 2018

Conversation

ZuZuD
Copy link
Contributor

@ZuZuD ZuZuD commented Mar 28, 2018 •
edited

SUMMARY

Fix issue #37834 - Error while raising WaitError exception in copy_snapshot() ('reason' is not a valid attribute)

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ec2_snapshot_copy

ANSIBLE VERSION

ansible 2.4.2.0

ADDITIONAL INFORMATION
>>> from botocore.exceptions import WaiterError
>>> dir(WaiterError)
['__class__', '__delattr__', '__dict__', '__doc__', '__format__', '__getattribute__',
 '__getitem__', '__getslice__', '__hash__', '__init__', '__module__', '__new__',
 '__reduce__', '__reduce_ex__', '__repr__', '__setattr__', '__setstate__', '__sizeof__',
 '__str__', '__subclasshook__', '__unicode__', '__weakref__', 'args', 'fmt',  'message']

@ansibot
Copy link
Contributor

ansibot commented Mar 28, 2018

cc @Deepakkothandan @willthames
click here for bot help

@ansibot ansibot added aws bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. support:community This issue/PR relates to code supported by the Ansible community. labels Mar 28, 2018
@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label Mar 29, 2018
s-hertel
s-hertel approved these changes Apr 2, 2018
View reviewed changes
lib/ansible/modules/cloud/amazon/ec2_snapshot_copy.py Outdated
@@ -143,7 +143,7 @@ def copy_snapshot(module, ec2):
)

except WaiterError as we:
module.fail_json(msg='An error occurred (%s) waiting for the snapshot to become available. (%s)' % (we.message, we.reason))
module.fail_json(msg='An error occurred waiting for the snapshot to become available. (%s)' % str(we), exception=traceback.format_exc())
except ClientError as ce:
module.fail_json(msg=ce.message, exception=traceback.format_exc(), **camel_dict_to_snake_dict(ce.response))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this. Do you mind fixing this one as well? ce.message won't exist on python3.
module.fail_json(msg=str(ce), exception=traceback.format_exc(), **camel_dict_to_snake_dict(ce.response))

@ZuZuD ZuZuD changed the title ec2_snapshot_copy: WaitError exception handling ec2_snapshot_copy: WaitError and ClientError exception handling Apr 2, 2018
@ZuZuD
Copy link
Contributor Author

ZuZuD commented Apr 2, 2018

That's updated @s-hertel

@willthames willthames merged commit 70bcc5e into ansible:devel Apr 3, 2018
@willthames
Copy link
Contributor

Merged, thanks @ZuZuD

@willthames willthames mentioned this pull request Apr 3, 2018
Closed
ryancurrah pushed a commit to ryancurrah/ansible that referenced this pull request Apr 4, 2018
@ZuZuD @ryancurrah
ec2_snapshot_copy: WaitError and ClientError exception handling (ansi…
e578fbc 
…ble#38072)
willthames pushed a commit that referenced this pull request Apr 6, 2018
@ZuZuD @willthames
ec2_snapshot_copy: Add wait_timeout module parameter (#38072) (#38243)
1f3b480 
* ec2_snapshot_copy: add wait_timeout parameter
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
@ZuZuD @ilicmilan
ec2_snapshot_copy: WaitError and ClientError exception handling (ansi…
68d0233 
…ble#38072)
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
@ZuZuD @ilicmilan
ec2_snapshot_copy: Add wait_timeout module parameter (ansible#38072) (a…
cec3695 
…nsible#38243)

* ec2_snapshot_copy: add wait_timeout parameter
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@s-hertel s-hertel s-hertel approved these changes

Assignees
No one assigned
Labels
aws bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. new_contributor This PR is the first contribution by a new community member. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ZuZuD @ansibot @willthames @s-hertel @jborean93