Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc formatting update for office_365_connector_card.py #38142

Merged
merged 2 commits into from Apr 2, 2018
Merged

Doc formatting update for office_365_connector_card.py #38142

merged 2 commits into from Apr 2, 2018

Conversation

cpitre
Copy link
Contributor

@cpitre cpitre commented Mar 30, 2018 •
edited by dagwieers

The two bullet items were about one single item; this module is not idempotent.
Therefore the two bullet items should be one.

+label: docsite_pr

SUMMARY
ISSUE TYPE
  • Feature Pull Request
  • New Module Pull Request
  • Bugfix Pull Request
  • Docs Pull Request
COMPONENT NAME
ANSIBLE VERSION
ADDITIONAL INFORMATION

@cpitre
Update office_365_connector_card.py
e3920f6 
The two bullet items were about one single item; this module is not idempotent.
Therefore the two bullet items should be one.

 label: docsite_pr
@ansibot
Copy link
Contributor

ansibot commented Mar 30, 2018

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/notification/office_365_connector_card.py:23:75: W291 trailing whitespace

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_maintainer Ansibot is unable to identify maintainers for this PR. (Check `author` in docs or BOTMETA.yml) needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. support:community This issue/PR relates to code supported by the Ansible community. labels Mar 30, 2018
@cpitre
Update office_365_connector_card.py
93e2bb6 
Removed trailing white space that caused the test failure.
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 30, 2018
@dagwieers dagwieers added the docsite_pr This PR is created from documentation using the "Edit on GitHub" link. label Mar 30, 2018
@sivel sivel changed the title Update office_365_connector_card.py Doc formatting update for office_365_connector_card.py Apr 2, 2018
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Apr 2, 2018
@sivel sivel merged commit 5d779fa into ansible:devel Apr 2, 2018
ryancurrah pushed a commit to ryancurrah/ansible that referenced this pull request Apr 4, 2018
@cpitre @ryancurrah
Doc formatting update for office_365_connector_card.py (ansible#38142)
a8bfec0 
* Update office_365_connector_card.py

The two bullet items were about one single item; this module is not idempotent.
Therefore the two bullet items should be one.

 label: docsite_pr

* Update office_365_connector_card.py

Removed trailing white space that caused the test failure.
@gundalow gundalow added docsite_pr This PR is created from documentation using the "Edit on GitHub" link. and removed docsite_pr This PR is created from documentation using the "Edit on GitHub" link. labels Apr 9, 2018
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
@cpitre @ilicmilan
Doc formatting update for office_365_connector_card.py (ansible#38142)
0bb6834 
* Update office_365_connector_card.py

The two bullet items were about one single item; this module is not idempotent.
Therefore the two bullet items should be one.

 label: docsite_pr

* Update office_365_connector_card.py

Removed trailing white space that caused the test failure.
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
community_review In order to be merged, this PR must follow the community review workflow. docsite_pr This PR is created from documentation using the "Edit on GitHub" link. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_maintainer Ansibot is unable to identify maintainers for this PR. (Check `author` in docs or BOTMETA.yml) new_contributor This PR is the first contribution by a new community member. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cpitre @ansibot @sivel @dagwieers @gundalow