Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restrore showing stderr on script success #38177

Merged
merged 3 commits into from
Apr 10, 2018
Merged

restrore showing stderr on script success #38177

merged 3 commits into from
Apr 10, 2018

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Apr 2, 2018

SUMMARY

accidentally removed during transition to plugin, with toggle for those
who prefer the quiet way

fixes #33776

ISSUE TYPE
  • Feature Pull Request
  • Bugfix Pull Request
COMPONENT NAME

inventory/plugins/script

ANSIBLE VERSION
2.5-2.6

@bcoca bcoca mentioned this pull request Apr 2, 2018
Closed
@ansibot ansibot added feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Apr 2, 2018
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Apr 2, 2018
@bcoca bcoca requested a review from jctanner April 2, 2018 14:23
jctanner
jctanner approved these changes Apr 2, 2018
View reviewed changes
Copy link
Contributor

@jctanner jctanner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Apr 2, 2018
@ryanpetrello
Copy link
Contributor

Is this likely to be backported to 2.5?

@bcoca bcoca added this to To Do in 2.5.x blocker list via automation Apr 4, 2018
@bcoca
restrore showing stderr on script success
171d479 
accidentally removed during transition to plugin, with toggle for those
who prefer the quiet way

fixes ansible#33776
@bcoca
stderr display if no other errors capture first
0560b80
@bcoca
fixed issue with error encoding
8b1c643
@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Apr 10, 2018
@bcoca bcoca merged commit eef70d0 into ansible:devel Apr 10, 2018
@bcoca bcoca deleted the script_stderr branch April 10, 2018 21:16
samdoran pushed a commit to samdoran/ansible that referenced this pull request Apr 11, 2018
@bcoca @samdoran
restrore showing stderr on script success (ansible#38177)
de51cee 
* restore showing stderr on script success

accidentally removed during transition to plugin, with toggle for those
who prefer the quiet way

fixes ansible#33776

* stderr display if no other errors capture first
* fixed issue with error encoding

(cherry picked from commit eef70d0)
This was referenced Apr 11, 2018
Merged
Merged
samdoran pushed a commit that referenced this pull request Apr 11, 2018
@bcoca @samdoran
restrore showing stderr on script success (#38177)
7848413 
* restore showing stderr on script success

accidentally removed during transition to plugin, with toggle for those
who prefer the quiet way

fixes #33776

* stderr display if no other errors capture first
* fixed issue with error encoding

(cherry picked from commit eef70d0)
@nitzmahone nitzmahone moved this from To Do to Done in 2.5.x blocker list Apr 18, 2018
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
@bcoca @ilicmilan
restrore showing stderr on script success (ansible#38177)
ae904ad 
* restrore showing stderr on script success

accidentally removed during transition to plugin, with toggle for those
who prefer the quiet way

fixes ansible#33776

* stderr display if no other errors capture first
* fixed issue with error encoding
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jctanner jctanner jctanner approved these changes

Assignees
No one assigned
Labels
feature This issue/PR relates to a feature request. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
No open projects
2.5.x blocker list
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ansible-inventory doesn't pass through stderr for inventory scripts
4 participants
@bcoca @ryanpetrello @jctanner @ansibot