Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ovirt_templates: Add operating system attribute #38211

Merged
merged 1 commit into from
Apr 6, 2018
Merged

ovirt_templates: Add operating system attribute #38211

merged 1 commit into from
Apr 6, 2018

Conversation

machacekondra
Copy link
Contributor

SUMMARY

Add operating_system attribute to ovirt_templates module.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ovirt_templates

ANSIBLE VERSION
2.5.0
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Apr 3, 2018

cc @mwperina
click here for bot help

@ansibot ansibot added cloud community_review In order to be merged, this PR must follow the community review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. virt Virt community (incl. QEMU, KVM, libvirt, ovirt, RHV and Proxmox) owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community. labels Apr 3, 2018
@ansibot
Copy link
Contributor

ansibot commented Apr 3, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 2 errors:

lib/ansible/modules/cloud/ovirt/ovirt_templates.py:0:0: E309 version_added for new option (operating_system) should be 2.6. Currently 2.5
lib/ansible/modules/cloud/ovirt/ovirt_templates.py:0:0: E326 Value for "choices" from the argument_spec ([]) for "operating_system" does not match the documentation (['debian_7', 'freebsd', 'freebsdx64', 'other', 'other_linux', 'other_linux_ppc64', 'other_ppc64', 'rhel_3', 'rhel_4', 'rhel_4x64', 'rhel_5', 'rhel_5x64', 'rhel_6', 'rhel_6x64', 'rhel_6_ppc64', 'rhel_7x64', 'rhel_7_ppc64', 'sles_11', 'sles_11_ppc64', 'ubuntu_12_04', 'ubuntu_12_10', 'ubuntu_13_04', 'ubuntu_13_10', 'ubuntu_14_04', 'ubuntu_14_04_ppc64', 'windows_10', 'windows_10x64', 'windows_2003', 'windows_2003x64', 'windows_2008', 'windows_2008x64', 'windows_2008r2x64', 'windows_2008R2x64', 'windows_2012x64', 'windows_2012R2x64', 'windows_7', 'windows_7x64', 'windows_8', 'windows_8x64', 'windows_xp'])

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. owner_pr This PR is made by the module's maintainer. labels Apr 3, 2018
petr-balogh added a commit to petr-balogh/ovirt-ansible-image-template that referenced this pull request Apr 4, 2018
@petr-balogh
Add operating_system option
3dd2b0c 
Once PR ansible/ansible#38211 gets merged this
patch adds posibility to use this option from image-template role.
petr-balogh added a commit to petr-balogh/ovirt-ansible-image-template that referenced this pull request Apr 4, 2018
@petr-balogh
Add operating_system option
e25d400 
Once PR ansible/ansible#38211 gets merged this
patch adds posibility to use this option from image-template role.
@petr-balogh petr-balogh mentioned this pull request Apr 4, 2018
Merged
@machacekondra
ovirt_templates: Add new attributes
fe73337 
 - operating_system
 - memory
 - memory_guaranteed
 - memory_max
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. owner_pr This PR is made by the module's maintainer. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 5, 2018
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Apr 5, 2018
@machacekondra
Copy link
Contributor Author

shipit

1 similar comment
@mwperina
Copy link
Contributor

mwperina commented Apr 6, 2018

shipit

@ansibot ansibot added automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. labels Apr 6, 2018
@ansibot ansibot merged commit fc7a688 into ansible:devel Apr 6, 2018
petr-balogh added a commit to petr-balogh/ovirt-ansible-image-template that referenced this pull request Apr 11, 2018
@petr-balogh
Add params for os and memory
589208d 
PR ansible/ansible#38211 got merged but will be
available in 2.6.
This patch adds posibility to use these params from image-template role.
petr-balogh added a commit to petr-balogh/ovirt-ansible-image-template that referenced this pull request Apr 11, 2018
@petr-balogh
Add params for os and memory
7322508 
PR ansible/ansible#38211 got merged but will be
available in 2.6.
This patch adds posibility to use these params from image-template role.
machacekondra pushed a commit to oVirt/ovirt-ansible-image-template that referenced this pull request Apr 13, 2018
@petr-balogh @machacekondra
Add params for os and memory
af9cc4b 
PR ansible/ansible#38211 got merged but will be
available in 2.6.
This patch adds posibility to use these params from image-template role.
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
@machacekondra @ilicmilan
ovirt_templates: Add new attributes (ansible#38211)
f219d8d 
- operating_system
 - memory
 - memory_guaranteed
 - memory_max
@dagwieers dagwieers added ovirt oVirt and RHV community and removed virt Virt community (incl. QEMU, KVM, libvirt, ovirt, RHV and Proxmox) labels Feb 21, 2019
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
automerge This PR was automatically merged by ansibot. cloud feature This issue/PR relates to a feature request. module This issue/PR relates to a module. ovirt oVirt and RHV community owner_pr This PR is made by the module's maintainer. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@machacekondra @ansibot @mwperina @dagwieers @samdoran