Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return virtual_facts after VMware platform detection #38237

Merged
merged 1 commit into from
Apr 23, 2018
Merged

Return virtual_facts after VMware platform detection #38237

merged 1 commit into from
Apr 23, 2018

Conversation

bmfp
Copy link
Contributor

@bmfp bmfp commented Apr 3, 2018 •
edited

SUMMARY

We need to return virtual_facts after VMware platform detection, otherwise we're falling back to 'NA' type and role

This is an addition to PR #34925

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

virtual_facts

ANSIBLE VERSION
2.6.0 0.0.devel
ADDITIONAL INFORMATION

@ansibot ansibot added bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 3, 2018
Akasurde
Akasurde approved these changes Apr 4, 2018
View reviewed changes
Copy link
Member

@Akasurde Akasurde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Akasurde Akasurde requested a review from alikins April 4, 2018 04:20
@Akasurde Akasurde removed the needs_triage Needs a first human triage before being processed. label Apr 4, 2018
@Akasurde Akasurde changed the title We need to return virtual_facts after VMWare platform detection Return virtual_facts after VMWare platform detection Apr 4, 2018
@bmfp bmfp changed the title Return virtual_facts after VMWare platform detection Return virtual_facts after VMware platform detection Apr 4, 2018
alikins
alikins approved these changes Apr 4, 2018
View reviewed changes
Copy link
Contributor

@alikins alikins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@alikins
Copy link
Contributor

alikins commented Apr 4, 2018

(for bot)
!rebuild_merge

@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Apr 4, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 12, 2018
@Akasurde
Copy link
Member

rebuild_merge

@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 23, 2018
@ansibot ansibot merged commit 4f36d79 into ansible:devel Apr 23, 2018
@Akasurde
Copy link
Member

@bmfp Thanks for the contribution. @alikins Thanks for review.

Akasurde pushed a commit to Akasurde/ansible that referenced this pull request Apr 23, 2018
@bmfp @Akasurde
We need to return virtual_facts after VMWare platform detection (ansi…
5753f85 
…ble#38237)

(cherry picked from commit 4f36d79)
This was referenced Apr 23, 2018
Closed
Closed
@MartinNowak
Copy link

As was mentioned here #34132 (comment)

oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 14, 2018
@bmfp
We need to return virtual_facts after VMWare platform detection (ansi…
2a7f770 
…ble#38237)
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 15, 2018
@bmfp
We need to return virtual_facts after VMWare platform detection (ansi…
4d8b9fd 
…ble#38237)
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
@bmfp @ilicmilan
We need to return virtual_facts after VMWare platform detection (ansi…
d6f1f9c 
…ble#38237)
@dagwieers dagwieers added the vmware VMware community label Feb 10, 2019
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alikins alikins alikins approved these changes

@Akasurde Akasurde Akasurde approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug. cloud new_contributor This PR is the first contribution by a new community member. support:core This issue/PR relates to code supported by the Ansible Engineering Team. vmware VMware community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@bmfp @alikins @Akasurde @MartinNowak @dagwieers @ansibot