Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in Slack Callback plugin #38268

Merged
merged 1 commit into from
Apr 4, 2018
Merged

Fix typo in Slack Callback plugin #38268

merged 1 commit into from
Apr 4, 2018

Conversation

dminca
Copy link
Contributor

@dminca dminca commented Apr 4, 2018 •
edited

SUMMARY

get_options is an undefined method from CallbackBase

As a result, remove the trailing s letter.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • slack callback plugin
ANSIBLE VERSION
ansible 2.5.0
  config file = None
  configured module search path = ['/home/dminca/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python3.6/site-packages/ansible
  executable location = /usr/sbin/ansible
  python version = 3.6.4 (default, Jan  5 2018, 02:35:40) [GCC 7.2.1 20171224]
ADDITIONAL INFORMATION

@dminca
Fix typo in Slack Callback plugin
0411c60 
`get_options` is an undefined method from CallbackBase

As a result, remove the trailing `s` letter.

Signed-off-by: Daniel Andrei Minca <mandrei17@gmail.com>
@ansibot ansibot added bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. python3 support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Apr 4, 2018
webknjaz
webknjaz approved these changes Apr 4, 2018
View reviewed changes
Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@webknjaz webknjaz removed the needs_triage Needs a first human triage before being processed. label Apr 4, 2018
@webknjaz webknjaz merged commit 19ca1b2 into ansible:devel Apr 4, 2018
@webknjaz
Copy link
Member

webknjaz commented Apr 4, 2018

@dminca could you also submit a PR against stable-2.5, please?

@dminca
Copy link
Contributor Author

dminca commented Apr 4, 2018 •
edited

Sure thing @webknjaz 👍

I've cherry-picked it on stable-2.5, just to keep it clean, is that ok?

Thank you very much 🙇‍♂️

ryancurrah pushed a commit to ryancurrah/ansible that referenced this pull request Apr 4, 2018
@dminca @ryancurrah
Fix typo in Slack Callback plugin (ansible#38268)
605ee43 
`get_options` is an undefined method from CallbackBase

As a result, remove the trailing `s` letter.

Signed-off-by: Daniel Andrei Minca <mandrei17@gmail.com>
@dminca dminca mentioned this pull request Apr 4, 2018
Merged
@dminca dminca deleted the fix/slack-callback-plugin branch April 5, 2018 14:47
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
@dminca @ilicmilan
Fix typo in Slack Callback plugin (ansible#38268)
7423bd3 
`get_options` is an undefined method from CallbackBase

As a result, remove the trailing `s` letter.

Signed-off-by: Daniel Andrei Minca <mandrei17@gmail.com>
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@webknjaz webknjaz webknjaz approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug. python3 support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dminca @webknjaz @ansibot