Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slack Callback fix integration with stable-2.5 #38286

Merged
merged 1 commit into from
Apr 5, 2018

Conversation

dminca
Copy link
Contributor

@dminca dminca commented Apr 4, 2018

SUMMARY

get_options is an undefined method from CallbackBase

As a result, remove the trailing s letter.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • slack callback plugin
ANSIBLE VERSION

ADDITIONAL INFORMATION

Relates to: #38268

`get_options` is an undefined method from CallbackBase

As a result, remove the trailing `s` letter.

Signed-off-by: Daniel Andrei Minca <mandrei17@gmail.com>
@dminca dminca changed the title Fix typo in Slack Callback plugin Slack Callback fix integration with stable-2.5 Apr 4, 2018
@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Apr 4, 2018
@webknjaz webknjaz removed the needs_triage Needs a first human triage before being processed. label Apr 4, 2018
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 4, 2018
@webknjaz webknjaz merged commit 5cf1420 into ansible:stable-2.5 Apr 5, 2018
@dminca dminca deleted the fix/merge-fix-2-5-stable branch April 5, 2018 14:47
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.5 This issue/PR affects Ansible v2.5 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants