Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOCS: Network Best Practices fixes #38293

Merged
merged 2 commits into from
Apr 5, 2018
Merged

DOCS: Network Best Practices fixes #38293

merged 2 commits into from
Apr 5, 2018

Conversation

acozine
Copy link
Contributor

@acozine acozine commented Apr 4, 2018

SUMMARY

Closes #38217
Closes #35649
Corrects Network Best Practices page

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

http://docs.ansible.com/ansible/devel/network/user_guide/network_best_practices_2.5.html

ANSIBLE VERSION

2.5

@acozine acozine added this to Docsite work in Ansible-maintained Collections Documentation via automation Apr 4, 2018
@acozine acozine moved this from Docsite work to In progress in Ansible-maintained Collections Documentation Apr 4, 2018
@ansibot
Copy link
Contributor

ansibot commented Apr 4, 2018

cc @dharmabumstead @gundalow
click here for bot help

@ansibot ansibot added docs This issue/PR relates to or includes documentation. needs_triage Needs a first human triage before being processed. networking Network category support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Apr 4, 2018
@gundalow gundalow removed the needs_triage Needs a first human triage before being processed. label Apr 5, 2018
@kmarquis
Copy link

kmarquis commented Apr 5, 2018

@gundalow that looks perfect from what i was asking 👍

@dharmabumstead dharmabumstead merged commit 24fe867 into ansible:devel Apr 5, 2018
Ansible-maintained Collections Documentation automation moved this from In progress to Done Apr 5, 2018
acozine pushed a commit to acozine/ansible that referenced this pull request Apr 5, 2018
DOCS: Network Best Practices fixes (ansible#38293)
c33272c 
* fixes typo per ansible#38217, corrects link anchor

* adds ssh-agent info per ansible#35649

(cherry picked from commit 24fe867)
gundalow pushed a commit that referenced this pull request Apr 6, 2018
@gundalow
DOCS: Network Best Practices fixes (#38293) (#38360)
222c1f1 
* fixes typo per #38217, corrects link anchor

* adds ssh-agent info per #35649

(cherry picked from commit 24fe867)
@acozine acozine deleted the best_practices_fixes branch April 13, 2018 16:50
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
@ilicmilan
DOCS: Network Best Practices fixes (ansible#38293)
78157aa 
* fixes typo per ansible#38217, corrects link anchor

* adds ssh-agent info per ansible#35649
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gundalow gundalow gundalow approved these changes

@dharmabumstead dharmabumstead dharmabumstead approved these changes

Assignees
No one assigned
Labels
docs This issue/PR relates to or includes documentation. networking Network category support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
No open projects
Ansible-maintained Collections Docume...
  
Done
Milestone
No milestone
5 participants
@acozine @ansibot @kmarquis @gundalow @dharmabumstead