Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow incremental update for vars in loop for set_fact/include_vars #38302

Merged
merged 3 commits into from
Apr 5, 2018
Merged

allow incremental update for vars in loop for set_fact/include_vars #38302

merged 3 commits into from
Apr 5, 2018

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Apr 4, 2018 •
edited

SUMMARY

fixes #38271

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

set_fact/include_vars

ANSIBLE VERSION
2.5/2.6

@bcoca bcoca added this to To Do in 2.5.x blocker list via automation Apr 4, 2018
@bcoca bcoca changed the title Sf iv allow incremental update for vars in loop for set_fact/include_vars Apr 4, 2018
@ansibot
Copy link
Contributor

ansibot commented Apr 4, 2018

cc @dagwieers
click here for bot help

@ansibot ansibot added bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Apr 4, 2018
@sivel sivel mentioned this pull request Apr 5, 2018
Closed
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Apr 5, 2018
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 5, 2018
@willthames
Copy link
Contributor

Also fixes #38075

@willthames willthames self-requested a review April 5, 2018 23:23
@willthames willthames merged commit 2afb109 into ansible:devel Apr 5, 2018
@willthames willthames mentioned this pull request Apr 5, 2018
Closed
@bcoca bcoca deleted the sf_iv branch April 6, 2018 00:26
@nitzmahone nitzmahone moved this from To Do to 2.5.2 holding in 2.5.x blocker list Apr 18, 2018
This was referenced Apr 19, 2018
Closed
Closed
@lae lae mentioned this pull request Apr 19, 2018
Closed
@sivel sivel mentioned this pull request Apr 19, 2018
Closed
This was referenced Apr 20, 2018
Closed
Closed
Closed
@sivel sivel mentioned this pull request Apr 23, 2018
Closed
@bcoca bcoca mentioned this pull request Apr 23, 2018
Closed
@sivel sivel mentioned this pull request Apr 23, 2018
Closed
sivel pushed a commit to sivel/ansible that referenced this pull request Apr 23, 2018
@bcoca @sivel
allow incremental update for vars in loop for set_fact/include_vars (a…
81daf0d 
…nsible#38302)

* fix set_fact/include_vars looping

* tests for all behaviours affected

* add tests with injection off/on

(cherry picked from commit 2afb109)
sivel added a commit to sivel/ansible that referenced this pull request Apr 23, 2018
@sivel
Add changelog for ansible#38302
a7ff943
@sivel sivel mentioned this pull request Apr 23, 2018
Merged
ansibot pushed a commit that referenced this pull request Apr 23, 2018
@bcoca @ansibot
allow incremental update for vars in loop for set_fact/include_vars (#…
711769d 
…38302)

* fix set_fact/include_vars looping

* tests for all behaviours affected

* add tests with injection off/on

(cherry picked from commit 2afb109)
ansibot pushed a commit that referenced this pull request Apr 23, 2018
@sivel @ansibot
Add changelog for #38302
ec8bce2
@Akasurde Akasurde mentioned this pull request Apr 24, 2018
Closed
This was referenced Apr 24, 2018
Closed
Closed
Closed
@bcoca bcoca mentioned this pull request Apr 25, 2018
Closed
This was referenced Apr 26, 2018
Closed
Closed
Closed
This was referenced Apr 26, 2018
Closed
Closed
@bcoca bcoca moved this from 2.5.2 holding to Done in 2.5.x blocker list Apr 27, 2018
@bcoca bcoca mentioned this pull request Apr 27, 2018
Closed
@sivel sivel mentioned this pull request Apr 27, 2018
Closed
@bcoca bcoca mentioned this pull request Apr 27, 2018
Closed
@Akasurde Akasurde mentioned this pull request Apr 30, 2018
Closed
@Akasurde Akasurde mentioned this pull request May 2, 2018
Closed
@chrigl chrigl mentioned this pull request Jun 14, 2018
Closed
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
@bcoca @ilicmilan
allow incremental update for vars in loop for set_fact/include_vars (a…
5e7df94 
…nsible#38302)

* fix set_fact/include_vars looping

* tests for all behaviours affected

* add tests with injection off/on
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@willthames willthames willthames approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
No open projects
2.5.x blocker list
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

set_fact and with_items broken
3 participants
@bcoca @ansibot @willthames