Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: apt, yum: add example with package lists #38333

Merged
merged 1 commit into from
Apr 6, 2018
Merged

doc: apt, yum: add example with package lists #38333

merged 1 commit into from
Apr 6, 2018

Conversation

resmo
Copy link
Contributor

@resmo resmo commented Apr 5, 2018

SUMMARY

added a user friendly example how to handle a list of packages

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

yum, apt

ANSIBLE VERSION
2.6
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Apr 5, 2018

cc @Akasurde @berenddeschouwer @mgwilliams @mkrizek @verm666
click here for bot help

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Apr 5, 2018
@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Apr 5, 2018
@mkrizek mkrizek merged commit af35983 into ansible:devel Apr 6, 2018
@resmo resmo deleted the doc/apt-yum-list-names branch April 6, 2018 17:58
@weisslj
Copy link
Contributor

weisslj commented May 2, 2018

Hi! The example seems rather complicated:

- name: Install a list of packages
  apt:
    name: "{{ packages }}"
  vars:
    packages:
    - foo
    - foo-tools

Wouldn't it be shorter and more clearer to write:

- name: Install a list of packages
  apt:
    name:
    - foo
    - foo-tools

ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
@resmo @ilicmilan
doc: apt, yum: add example with package lists (ansible#38333)
a7f7f14
@dagwieers dagwieers added the packaging Packaging category label Mar 3, 2019
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mkrizek mkrizek mkrizek approved these changes

Assignees
No one assigned
Labels
core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. packaging Packaging category support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@resmo @ansibot @weisslj @mkrizek @dagwieers