Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace the hard-coded temp path in gunicorn module #38349

Merged
merged 1 commit into from
Apr 5, 2018
Merged

Replace the hard-coded temp path in gunicorn module #38349

merged 1 commit into from
Apr 5, 2018

Conversation

ericwb
Copy link
Contributor

@ericwb ericwb commented Apr 5, 2018

SUMMARY

The gunicorn module has a hard-coded reference to '/tmp' which may
or may not be the actual temp directory for an operating system.

This patch replaces '/tmp' with module.tmpdir which should
resolve to the correct temp directory for the OS.

Fixes Issue #36953

Signed-off-by: Eric Brown browne@vmware.com

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/web_infrastructure/gunicorn.py

ANSIBLE VERSION
ansible 2.5.0
  config file = None
  configured module search path = [u'/Users/browne/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /Library/Python/2.7/site-packages/ansible
  executable location = /usr/local/bin/ansible
  python version = 2.7.10 (default, Feb  7 2017, 00:08:15) [GCC 4.2.1 Compatible Apple LLVM 8.0.0 (clang-800.0.34)]
ADDITIONAL INFORMATION

@ericwb
Replace the hard-coded temp path in gunicorn module
aec7444 
The gunicorn module has a hard-coded reference to '/tmp' which may
or may not be the actual temp directory for an operating system.

This patch replaces '/tmp' with module.tmpdir which should
resolve to the correct temp directory for the OS.

Fixes Issue #36953

Signed-off-by: Eric Brown <browne@vmware.com>
@ansibot
Copy link
Contributor

ansibot commented Apr 5, 2018

cc @agmezr
click here for bot help

@ansibot ansibot added bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. labels Apr 5, 2018
@samdoran samdoran merged commit 4e38036 into ansible:devel Apr 5, 2018
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Apr 5, 2018
@ericwb ericwb deleted the gunicorn branch May 24, 2018 03:56
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
@ericwb @ilicmilan
Replace the hard-coded temp path in gunicorn module (ansible#38349)
32b80a5 
The gunicorn module has a hard-coded reference to '/tmp' which may
or may not be the actual temp directory for an operating system.

This patch replaces '/tmp' with module.tmpdir which should
resolve to the correct temp directory for the OS.

Fixes Issue ansible#36953

Signed-off-by: Eric Brown <browne@vmware.com>
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ericwb @ansibot @samdoran