Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

synchronize module: Default rsync_opts to empty list #38374

Merged
merged 1 commit into from May 25, 2018
Merged

synchronize module: Default rsync_opts to empty list #38374

merged 1 commit into from May 25, 2018

Conversation

willthames
Copy link
Contributor

SUMMARY

Ensure that if rsync_opts is not set, it defaults to an empty list rather than None.

Otherwise python fails when it tries to iterate over None.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

synchronize

ANSIBLE VERSION
ansible 2.6.0 (devel 79c5a34b0b) last updated 2018/04/06 16:49:43 (GMT +1000)
  config file = None
  configured module search path = [u'/home/will/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /home/will/src/ansible/lib/ansible
  executable location = /home/will/src/ansible/bin/ansible
  python version = 2.7.14 (default, Mar 14 2018, 13:36:31) [GCC 7.3.1 20180303 (Red Hat 7.3.1-5)]

Default rsync_opts to empty list
c527844 
Otherwise python fails when it tries to iterate over `None`.
@ansibot
Copy link
Contributor

ansibot commented Apr 6, 2018

cc @tima
click here for bot help

@ansibot ansibot added bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Apr 6, 2018
@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Apr 6, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 14, 2018
@ansibot ansibot added the affects_2.6 This issue/PR affects Ansible v2.6 label May 24, 2018
@maxamillion
Copy link
Contributor

rebuild_merge

@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label May 25, 2018
@ansibot ansibot merged commit bbe57cb into ansible:devel May 25, 2018
@ansible ansible locked and limited conversation to collaborators May 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.6 This issue/PR affects Ansible v2.6 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@willthames @ansibot @maxamillion @mkrizek