Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation on dict2items #38375

Merged
merged 1 commit into from
Apr 7, 2018
Merged

Add documentation on dict2items #38375

merged 1 commit into from
Apr 7, 2018

Conversation

willthames
Copy link
Contributor

SUMMARY

dict2items is worth mentioning in the filters and loops pages
(the latter as it's useful to replace with_dict)

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

playbooks_loops
playbooks_filters

ANSIBLE VERSION
ansible 2.6.0 (devel 79c5a34b0b) last updated 2018/04/06 16:49:43 (GMT +1000)
  config file = None
  configured module search path = [u'/home/will/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /home/will/src/ansible/lib/ansible
  executable location = /home/will/src/ansible/bin/ansible
  python version = 2.7.14 (default, Mar 14 2018, 13:36:31) [GCC 7.3.1 20180303 (Red Hat 7.3.1-5)]
ADDITIONAL INFORMATION

Succeeds #33959

@ansibot
Copy link
Contributor

ansibot commented Apr 6, 2018

cc @dharmabumstead
click here for bot help

@ansibot ansibot added docs This issue/PR relates to or includes documentation. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Apr 6, 2018
@willthames
Copy link
Contributor Author

I've mostly tested these docs changes, but iterating on them is hard as it consumes my entire machine for 2 hours, even if I restrict it to only build one modules.

Needs #33959 to be merged (once seemingly unrelated test failures go away)

@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Apr 6, 2018
@dharmabumstead
Copy link
Contributor

@willthames have you seen this? #38311

@willthames
Copy link
Contributor Author

willthames commented Apr 6, 2018 •
edited

@dharmabumstead - I hadn't - that makes life a lot easier - thanks for doing that work!

Add documentation on dict2items
cfe49c5 
dict2items is worth mentioning in the filters and loops pages
(the latter as it's useful to replace `with_dict`)

Update some nearby broken links
dharmabumstead
dharmabumstead approved these changes Apr 6, 2018
View reviewed changes
Copy link
Contributor

@dharmabumstead dharmabumstead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @willthames!

@dharmabumstead dharmabumstead merged commit a8953fc into ansible:devel Apr 7, 2018
@mattclay mattclay mentioned this pull request Apr 30, 2018
Merged
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
@willthames @ilicmilan
Add documentation on dict2items (ansible#38375)
8fd0ef4 
dict2items is worth mentioning in the filters and loops pages
(the latter as it's useful to replace `with_dict`)

Update some nearby broken links
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bcoca bcoca bcoca approved these changes

@dharmabumstead dharmabumstead dharmabumstead approved these changes

Assignees
No one assigned
Labels
docs This issue/PR relates to or includes documentation. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@willthames @ansibot @dharmabumstead @bcoca @mkrizek