-
Notifications
You must be signed in to change notification settings - Fork 23.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apt: allow for --allow-unauthenticated in upgrade #38381
Merged
mkrizek
merged 4 commits into
ansible:devel
from
mkrizek:36799-unauthenticated-upgrade-fix
Apr 10, 2018
Merged
apt: allow for --allow-unauthenticated in upgrade #38381
mkrizek
merged 4 commits into
ansible:devel
from
mkrizek:36799-unauthenticated-upgrade-fix
Apr 10, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webknjaz
approved these changes
Apr 10, 2018
webknjaz
reviewed
Apr 10, 2018
@@ -739,7 +739,8 @@ def cleanup(m, purge=False, force=False, operation=None, | |||
|
|||
def upgrade(m, mode="yes", force=False, default_release=None, | |||
use_apt_get=False, | |||
dpkg_options=expand_dpkg_options(DPKG_OPTIONS), autoremove=False): | |||
dpkg_options=expand_dpkg_options(DPKG_OPTIONS), autoremove=False, | |||
allow_unauthenticated=False): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you please add trailing comma and move ):
to the next line?
ilicmilan
pushed a commit
to ilicmilan/ansible
that referenced
this pull request
Nov 7, 2018
* apt: allow for --allow-unauthenticated in upgrade * Style fix * Another style fix * Add trailing comma
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
bug
This issue/PR relates to a bug.
core_review
In order to be merged, this PR must follow the core review workflow.
module
This issue/PR relates to a module.
packaging
Packaging category
support:core
This issue/PR relates to code supported by the Ansible Engineering Team.
test
This PR relates to tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #36799
ISSUE TYPE
COMPONENT NAME
apt
ANSIBLE VERSION
ADDITIONAL INFORMATION