Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apt: allow for --allow-unauthenticated in upgrade #38381

Merged
merged 4 commits into from
Apr 10, 2018

Conversation

mkrizek
Copy link
Contributor

@mkrizek mkrizek commented Apr 6, 2018

SUMMARY

Fixes #36799

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

apt

ANSIBLE VERSION
devel
ADDITIONAL INFORMATION

@mkrizek mkrizek requested review from resmo and Akasurde April 6, 2018 08:22
@mkrizek mkrizek added this to READY TO REVIEW in CEM Apr 6, 2018
@ansibot
Copy link
Contributor

ansibot commented Apr 6, 2018

@ansibot ansibot added bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Apr 6, 2018
@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Apr 6, 2018
@mkrizek mkrizek requested a review from abadger April 9, 2018 13:49
@@ -739,7 +739,8 @@ def cleanup(m, purge=False, force=False, operation=None,

def upgrade(m, mode="yes", force=False, default_release=None,
use_apt_get=False,
dpkg_options=expand_dpkg_options(DPKG_OPTIONS), autoremove=False):
dpkg_options=expand_dpkg_options(DPKG_OPTIONS), autoremove=False,
allow_unauthenticated=False):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please add trailing comma and move ): to the next line?

@mkrizek mkrizek merged commit d97952d into ansible:devel Apr 10, 2018
@mkrizek mkrizek deleted the 36799-unauthenticated-upgrade-fix branch April 10, 2018 13:37
@mkrizek mkrizek moved this from READY TO REVIEW to DONE in CEM Apr 10, 2018
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
* apt: allow for --allow-unauthenticated in upgrade

* Style fix

* Another style fix

* Add trailing comma
@dagwieers dagwieers added the packaging Packaging category label Mar 3, 2019
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. packaging Packaging category support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
No open projects
CEM
DONE
Development

Successfully merging this pull request may close these issues.

apt does not pass allow_unauthenticated: yes for state=latest
4 participants