nxos_hsrp issues

[saichint]

ISSUE TYPE

• Bug Report

COMPONENT NAME

nxos_hsrp

ANSIBLE VERSION

ansible 2.6.0 (devel fed20b825f) last updated 2018/02/15 12:51:12 (GMT -400)
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /root/agents-ci/ansible/lib/ansible
  executable location = /root/agents-ci/ansible/bin/ansible
  python version = 2.7.6 (default, Oct 26 2016, 20:30:19) [GCC 4.8.4]

OS / ENVIRONMENT

SUMMARY

Ansible Server : Ubuntu 14.04
Device: N9K running 7.0(3)I2(5)

STEPS TO REPRODUCE

There are few issues with nxos_hsrp module

1. The default hsrp version is 1, the current code assumes it is 2 which is incorrect
2. There is no way to put virtual ip, priority and authentication to their defaults unless we remove the entire hsrp group
3. There is no way to configure an md5 authentication key string to be hidden (type 7) although platform supports it. Only we can configure type 0 for md5 now.
4. vip is an optional parameter as it is correctly mentioned in the documentation, however the code is forcing it to be required.
5. There are unnecessary range checks and if they are changed on platform side which causes issues in future.

Note: I will open a PR shortly to address the above issues

[ansibot]

Files identified in the description:

• lib/ansible/modules/network/nxos/nxos_hsrp.py

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

[ansibot]

cc @GGabriele @jedelman8 @mikewiebe @privateip @rahushen @rcarrillocruz @trishnaguha
click here for bot help