Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove python-keyczar dependency #38534

Merged
merged 3 commits into from
May 17, 2018
Merged

Conversation

samdoran
Copy link
Contributor

SUMMARY

python-keyczar is no longer needed since accelerate mode has been removed

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ansible.spec
PKGBUILD

ANSIBLE VERSION
2.6
ADDITIONAL INFORMATION

@ansibot ansibot added feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Apr 10, 2018
@webknjaz webknjaz removed the needs_triage Needs a first human triage before being processed. label Apr 10, 2018
@abadger
Copy link
Contributor

abadger commented Apr 11, 2018

+1 Looks like we could remove keyczar from the container images as well (dockerfiles: test/utils/docker/ )

@samdoran
Copy link
Contributor Author

I'll add that to this PR.

@ansibot
Copy link
Contributor

ansibot commented Apr 12, 2018

@ansibot ansibot added docker test This PR relates to tests. labels Apr 12, 2018
@mattclay
Copy link
Member

The containers are currently shared across branches, but we don't yet have a good way to manage differing requirements. I'm going to be making some changes to how we manage the containers, including moving them out of the repo. So lets hold off on updating these for now. I'll add python-keyczar to my list to review when the containers do get updated.

@samdoran
Copy link
Contributor Author

Sure thing. I'll put the package back in to the containers.

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 22, 2018
@samdoran
Copy link
Contributor Author

rebuild_merge

@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label May 17, 2018
@ansibot ansibot merged commit 02bc4c5 into ansible:devel May 17, 2018
achinthagunasekara pushed a commit to achinthagunasekara/ansible that referenced this pull request May 23, 2018
* Remove python-keyczar dependency

* Remove python-keyczare from Dockerfiles

* Revert "Remove python-keyczare from Dockerfiles"

This reverts commit 264be66.
jacum pushed a commit to jacum/ansible that referenced this pull request Jun 26, 2018
* Remove python-keyczar dependency

* Remove python-keyczare from Dockerfiles

* Revert "Remove python-keyczare from Dockerfiles"

This reverts commit 264be66.
samdoran added a commit to samdoran/ansible that referenced this pull request Aug 17, 2018
nitzmahone pushed a commit that referenced this pull request Sep 5, 2018
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
* Remove python-keyczar dependency

* Remove python-keyczare from Dockerfiles

* Revert "Remove python-keyczare from Dockerfiles"

This reverts commit 264be66.
@ansible ansible locked and limited conversation to collaborators May 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
docker feature This issue/PR relates to a feature request. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants