Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix nxos_igmp_snooping issues #38566

Merged
merged 2 commits into from
Apr 11, 2018
Merged

fix nxos_igmp_snooping issues #38566

merged 2 commits into from
Apr 11, 2018

Conversation

saichint
Copy link
Contributor

@saichint saichint commented Apr 10, 2018 •
edited

SUMMARY

fixes #38565

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

nxos_igmp_snooping

ANSIBLE VERSION
ansible 2.6.0 (devel fed20b825f) last updated 2018/02/15 12:51:12 (GMT -400)
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /root/agents-ci/ansible/lib/ansible
  executable location = /root/agents-ci/ansible/bin/ansible
  python version = 2.7.6 (default, Oct 26 2016, 20:30:19) [GCC 4.8.4]
ADDITIONAL INFORMATION
  • This PR fixes nxos_igmp_snooping issues #38565
  • Documentation corrections are made
  • Dead code removed
  • Integration tests are now corrected for platform dependency
  • All tests pass on all platforms

@ansibot
Copy link
Contributor

ansibot commented Apr 10, 2018

cc @GGabriele @jedelman8 @mikewiebe @privateip @rahushen @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category nxos Cisco NXOS community support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests. labels Apr 10, 2018
@ansibot
Copy link
Contributor

ansibot commented Apr 11, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

test/sanity/validate-modules/ignore.txt:1347:1: A102 Remove since "lib/ansible/modules/network/nxos/nxos_igmp_snooping.py" passes "E325" test

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Apr 11, 2018
@ansibot
Copy link
Contributor

ansibot commented Apr 11, 2018

cc @mattclay
click here for bot help

@ansibot ansibot added support:core This issue/PR relates to code supported by the Ansible Engineering Team. core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 11, 2018
@gundalow gundalow removed the needs_triage Needs a first human triage before being processed. label Apr 11, 2018
@trishnaguha trishnaguha merged commit ed42331 into ansible:devel Apr 11, 2018
@saichint saichint deleted the igmp branch April 11, 2018 14:51
trishnaguha pushed a commit to trishnaguha/ansible that referenced this pull request Apr 11, 2018
@trishnaguha
fix nxos_igmp_snooping issues (ansible#38566)
ac3fef1 
* fix nxos_igmp_snooping issue

* shippable error fix

(cherry picked from commit ed42331)
@trishnaguha
Copy link
Member

cherry-picked to 2.5

trishnaguha added a commit that referenced this pull request Apr 11, 2018
@trishnaguha
nxos_igmp_snooping fix cherry-pick (#38596)
91c8a8d 
* fix nxos_igmp_snooping issues (#38566)

* fix nxos_igmp_snooping issue

* shippable error fix

(cherry picked from commit ed42331)

* update nxos changelog

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
@trishnaguha trishnaguha moved this from To do to Done in zzz NOT USED: Networking Bugs Apr 17, 2018
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
@ilicmilan
fix nxos_igmp_snooping issues (ansible#38566)
8987d31 
* fix nxos_igmp_snooping issue

* shippable error fix
@dagwieers dagwieers added the cisco Cisco technologies label Feb 23, 2019
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trishnaguha trishnaguha trishnaguha approved these changes

Assignees

@trishnaguha trishnaguha

Labels
bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category nxos Cisco NXOS community support:core This issue/PR relates to code supported by the Ansible Engineering Team. support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests.
Projects
No open projects
zzz NOT USED: Networking Bugs
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nxos_igmp_snooping issues
5 participants
@saichint @ansibot @trishnaguha @dagwieers @gundalow