Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for GCP Compute Routes #38619

Merged
merged 1 commit into from
May 4, 2018
Merged

Adding support for GCP Compute Routes #38619

merged 1 commit into from
May 4, 2018

Conversation

rambleraptor
Copy link
Contributor

SUMMARY

Adding support for GCP Compute Routes

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

gcp_compute_route

ANSIBLE VERSION
2.6
ADDITIONAL INFORMATION

This was autogenerated using Magic Modules

@ansibot
Copy link
Contributor

ansibot commented Apr 11, 2018

cc @erjohnso
click here for bot help

@ansibot ansibot added cloud community_review In order to be merged, this PR must follow the community review workflow. gce module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. labels Apr 11, 2018
@ansibot
Copy link
Contributor

ansibot commented Apr 11, 2018

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/google/gcp_compute_route.py:240:0: ImportError: cannot import name GcpRequest

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/google/gcp_compute_route.py:240:0: ImportError: cannot import name GcpRequest

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/cloud/google/gcp_compute_route.py:240:0: ImportError: cannot import name 'GcpRequest'

The test ansible-test sanity --test import --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/google/gcp_compute_route.py:240:0: ImportError: cannot import name 'GcpRequest'

The test ansible-test sanity --test import --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/google/gcp_compute_route.py:240:0: ImportError: cannot import name 'GcpRequest' from 'ansible.module_utils.gcp_utils' (/root/ansible/test/sanity/import/lib/ansible/module_utils/gcp_utils.py)

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/google/gcp_compute_route.py:0:0: E321 Exception attempting to import module for argument_spec introspection, 'cannot import name 'GcpRequest''

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Apr 11, 2018
@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label Apr 12, 2018
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Apr 12, 2018
@ansibot
Copy link
Contributor

ansibot commented Apr 12, 2018

@GwenaelPellenArkeup @bennojoy @dohoangkhiem @erjohnso @GoogleCloudPlatform @nitaco @robwagner33 @supertom @walbert947

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 12, 2018
@ansibot
Copy link
Contributor

ansibot commented Apr 13, 2018

The test ansible-test sanity --test integration-aliases [explain] failed with 1 error:

test/integration/targets/gcp_compute_route/aliases:0:0: missing alias `posix/ci/cloud/group[1-5]/gcp` or `unsupported`

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Apr 13, 2018
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 13, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 21, 2018
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 27, 2018
ryansb
ryansb reviewed May 4, 2018
View reviewed changes
lib/ansible/modules/cloud/google/gcp_compute_route.py
next_hop_instance:
description:
- URL to an instance that should handle matching packets.
- 'You can specify this as a full or partial URL. For example: *
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This list formatting is a bit odd. Perhaps make it a normal sentence instead like:

You can specify this as a full or partial URL. For example: U(https://www.googleapis.com/compute/v1/projects/project/zones/zone/), U(https://www.googleapis.com/compute/v1/projects/project/zones/zone/), projects/project/zones/zone/instances/instance, or zones/zone/instances/instance

@ryansb ryansb merged commit 768a81d into ansible:devel May 4, 2018
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 12, 2018
@rambleraptor
New module: GCP Compute Routes (ansible#38619)
8b5694a
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 14, 2018
@rambleraptor
New module: GCP Compute Routes (ansible#38619)
48e0422
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 14, 2018
@rambleraptor
New module: GCP Compute Routes (ansible#38619)
1d55d96
tonal pushed a commit to tonal/ansible that referenced this pull request May 15, 2018
@rambleraptor
New module: GCP Compute Routes (ansible#38619)
1301e2e
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 15, 2018
@rambleraptor
New module: GCP Compute Routes (ansible#38619)
6957d33
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 15, 2018
@rambleraptor
New module: GCP Compute Routes (ansible#38619)
6b9dbb7
@rambleraptor rambleraptor deleted the gcp_compute_route branch July 11, 2018 23:06
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
@rambleraptor @ilicmilan
New module: GCP Compute Routes (ansible#38619)
3d1b94f
@ansible ansible locked and limited conversation to collaborators May 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryansb ryansb ryansb approved these changes

Assignees
No one assigned
Labels
cloud community_review In order to be merged, this PR must follow the community review workflow. gce module This issue/PR relates to a module. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rambleraptor @ansibot @ryansb @jborean93