VMware: correct documentation for datacenter #38718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
bug
Akasurde
removed
the
needs_triage
gundalow
requested changes
Apr 13, 2018
| - This is required if uuid is not supplied. | ||
| description: | ||
| - Name of the VM to work with. | ||
| - This is required if C(uuid) parameter is not supplied. |
There was a problem hiding this comment.
Do we also want mutually_exclusive=(['name', 'uuid'],),?
| description: | ||
| - Destination datacenter for the find operation. | ||
| - Deprecated in 2.5, will be removed in 2.9 release. | ||
| required: False |
There was a problem hiding this comment.
You can removed required: false lines as that's the default
| @@ -112,7 +111,7 @@ def main(): | |||
| argument_spec.update( | |||
| name=dict(type='str'), | |||
| uuid=dict(type='str'), | |||
| datacenter=dict(removed_in_version=2.9, type='str', required=True) | |||
| datacenter=dict(removed_in_version=2.9, type='str', required=False) | |||
There was a problem hiding this comment.
You can remove , required=False
ansibot
added
needs_revision
This fixes documentation related to datacenter in vmware_guest_find module. Fixes: ansible#38290 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
gundalow
approved these changes
Apr 13, 2018
|
@gundalow Thanks for review. I will cherry-pick for stable-2.5 |
ilicmilan
pushed a commit
to ilicmilan/ansible
that referenced
this pull request
Nov 7, 2018
This fixes documentation related to datacenter in vmware_guest_find module. Fixes: ansible#38290 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This fixes documentation related to datacenter in vmware_guest_find
module.
Fixes: #38290
Signed-off-by: Abhijeet Kasurde akasurde@redhat.com
ISSUE TYPE
COMPONENT NAME
lib/ansible/modules/cloud/vmware/vmware_guest_find.py
ANSIBLE VERSION