fix nxos_igmp_interface issues #38752

saichint · 2018-04-13T16:33:00Z

SUMMARY

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

nxos_igmp_interface

ANSIBLE VERSION

ansible 2.6.0 (devel fed20b825f) last updated 2018/02/15 12:51:12 (GMT -400)
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /root/agents-ci/ansible/lib/ansible
  executable location = /root/agents-ci/ansible/bin/ansible
  python version = 2.7.6 (default, Oct 26 2016, 20:30:19) [GCC 4.8.4]

ADDITIONAL INFORMATION

This PR fixes nxos_igmp_interface issues #38750 and nxos_igmp_interface oif_source and oif_prefix are lists but not strings #38753
Deprecates oif_prefix and oif_source but maintains backward compatibility
Introduces oif_ps as a new parameter to add/remove multiple prefix/sources.
Documentation corrections are made
Integration tests are enhanced for coverage and platform dependencies
All tests pass on all platforms

ansibot · 2018-04-13T16:39:34Z

cc @GGabriele @jedelman8 @mattclay @mikewiebe @privateip @rahushen @rcarrillocruz @trishnaguha
click here for bot help

ansibot · 2018-04-13T17:01:11Z

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/network/nxos/nxos_igmp_interface.py:0:0: E326 Value for "choices" from the argument_spec ([]) for "version" does not match the documentation (['2', '3'])

click here for bot help

ansibot · 2018-04-17T19:01:15Z

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/network/nxos/nxos_igmp_interface.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/network/nxos/nxos_igmp_interface.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/network/nxos/nxos_igmp_interface.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/network/nxos/nxos_igmp_interface.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/network/nxos/nxos_igmp_interface.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test docs-build [explain] failed with the error:

Command "/usr/bin/python test/sanity/code-smell/docs-build.py" returned exit status 1.
>>> Standard Error
Traceback (most recent call last):
  File "test/sanity/code-smell/docs-build.py", line 55, in <module>
    main()
  File "test/sanity/code-smell/docs-build.py", line 17, in main
    raise subprocess.CalledProcessError(sphinx.returncode, cmd, output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['make', 'singlehtmldocs']' returned non-zero exit status 2.

The test ansible-test sanity --test validate-modules [explain] failed with 5 errors:

lib/ansible/modules/network/nxos/nxos_igmp_interface.py:0:0: E324 Value for "default" from the argument_spec ('present') for "state" does not match the documentation (None)
lib/ansible/modules/network/nxos/nxos_igmp_interface.py:0:0: E325 argument_spec for "immediate_leave" defines type="bool" but documentation does not
lib/ansible/modules/network/nxos/nxos_igmp_interface.py:0:0: E325 argument_spec for "report_llg" defines type="bool" but documentation does not
lib/ansible/modules/network/nxos/nxos_igmp_interface.py:0:0: E325 argument_spec for "restart" defines type="bool" but documentation does not
lib/ansible/modules/network/nxos/nxos_igmp_interface.py:142:17: E302 DOCUMENTATION is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/network/nxos/nxos_igmp_interface.py:142:17: error DOCUMENTATION: syntax error: mapping values are not allowed here

click here for bot help

saichint · 2018-04-19T17:09:44Z

@gundalow Made changes you requested. Thanks for the suggestions.

ansibot · 2018-04-19T17:19:41Z

cc @dharmabumstead
click here for bot help

gundalow · 2018-04-20T07:59:40Z

test/integration/targets/nxos_igmp_interface/tests/common/sanity.yaml

+      oif_ps:
+        - {'prefix': '238.2.2.6'}
+        - {'prefix': '238.2.2.5'}
+        - {'source': '1.1.1.1', 'prefix': '238.2.2.5'}


Please no 1.1.1.1 use the documention ip ranges

Changed 1.1.1.1 to 192.168.0.1 (not sure if that is what you meant).
However, the device takes 1.1.1.1 so the ip itself is correct.

see below:

n9k-108(config-if)# sh run igmp

!Command: show running-config igmp
!Time: Fri Apr 20 14:55:54 2018

version 7.0(3)I7(2)

interface Ethernet1/1
ip igmp static-oif 239.2.2.2 source 1.1.1.1

gundalow · 2018-04-20T08:01:03Z

docs/docsite/rst/porting_guides/porting_guide_2.6.rst

@@ -22,7 +22,8 @@ No notable changes.
 Deprecated
 ==========

-No notable changes.
+* In the `nxos_igmp_interface` module, `oif_prefix` and `oif_source` properties are deprecated. Use


We can make nxos_igmp_interface a link, see porting_guide_2.5.rst for an example.

saichint · 2018-04-20T15:04:03Z

@gundalow Made changes as you requested. Let me know if you have more comments.

trishnaguha · 2018-04-23T09:01:27Z

docs/docsite/rst/porting_guides/porting_guide_2.6.rst

@@ -22,7 +22,8 @@ No notable changes.
 Deprecated
 ==========

-No notable changes.
+* In the :ref:`nxos_mtu <nxos_igmp_interface>` module, `oif_prefix` and `oif_source` properties are deprecated. Use


@saichint this looks like typo nxos_mtu?

@trishnaguha Yes, it is a copy/paste error. Thanks for catching it. Fixed

trishnaguha · 2018-04-23T15:08:45Z

Thanks for the PR.

* fix nxos_igmp_interface issues * shippable fix * fix oif_prefix and oif_source * shippable fix * shippable fix * shippable fix * add an example for oif_ps * review comments * review comments * more review comments * fix typo

fix nxos_igmp_interface issues

9e7c6c2

ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Apr 13, 2018

shippable fix

8384135

trishnaguha self-assigned this Apr 16, 2018

bcoca removed the needs_triage Needs a first human triage before being processed. label Apr 16, 2018

fix oif_prefix and oif_source

91a5cd9

sai chintalapudi added 3 commits April 17, 2018 15:14

shippable fix

fc3bc0e

shippable fix

ef69f1c

shippable fix

56a2120

ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Apr 19, 2018

review comments

928f400

ansibot added the docs This issue/PR relates to or includes documentation. label Apr 19, 2018

trishnaguha approved these changes Apr 20, 2018

View reviewed changes

gundalow reviewed Apr 20, 2018

View reviewed changes

more review comments

5facea0

gundalow approved these changes Apr 20, 2018

View reviewed changes

ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 20, 2018

trishnaguha reviewed Apr 23, 2018

View reviewed changes

trishnaguha added this to In Review in zzz NOT USED: Networking Bugs Apr 23, 2018

fix typo

f7e3322

trishnaguha merged commit 6eecbf1 into ansible:devel Apr 23, 2018

saichint mentioned this pull request Apr 23, 2018

nxos_igmp_interface oif_source and oif_prefix are lists but not strings #38753

Closed

saichint deleted the igmp branch April 23, 2018 15:17

trishnaguha moved this from In Review to Done in zzz NOT USED: Networking Bugs Apr 25, 2018

dagwieers added the cisco Cisco technologies label Feb 23, 2019

ansible locked and limited conversation to collaborators Apr 27, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix nxos_igmp_interface issues #38752

fix nxos_igmp_interface issues #38752

saichint commented Apr 13, 2018 •

edited

ansibot commented Apr 13, 2018

ansibot commented Apr 13, 2018

ansibot commented Apr 17, 2018

saichint commented Apr 19, 2018

ansibot commented Apr 19, 2018

gundalow Apr 20, 2018

saichint Apr 20, 2018 •

edited

gundalow Apr 20, 2018

saichint commented Apr 20, 2018

trishnaguha Apr 23, 2018

saichint Apr 23, 2018

trishnaguha commented Apr 23, 2018

fix nxos_igmp_interface issues #38752

fix nxos_igmp_interface issues #38752

Conversation

saichint commented Apr 13, 2018 • edited

SUMMARY

ISSUE TYPE

COMPONENT NAME

ANSIBLE VERSION

ADDITIONAL INFORMATION

ansibot commented Apr 13, 2018

ansibot commented Apr 13, 2018

ansibot commented Apr 17, 2018

saichint commented Apr 19, 2018

ansibot commented Apr 19, 2018

gundalow Apr 20, 2018

Choose a reason for hiding this comment

saichint Apr 20, 2018 • edited

Choose a reason for hiding this comment

gundalow Apr 20, 2018

Choose a reason for hiding this comment

saichint commented Apr 20, 2018

trishnaguha Apr 23, 2018

Choose a reason for hiding this comment

saichint Apr 23, 2018

Choose a reason for hiding this comment

trishnaguha commented Apr 23, 2018

saichint commented Apr 13, 2018 •

edited

saichint Apr 20, 2018 •

edited