Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yum: docs: name is not required #38758

Merged
merged 1 commit into from
Apr 16, 2018
Merged

yum: docs: name is not required #38758

merged 1 commit into from
Apr 16, 2018

Conversation

mkrizek
Copy link
Contributor

@mkrizek mkrizek commented Apr 13, 2018

SUMMARY

Mentioned in #30088 (comment)

Either name or list is required
https://github.com/ansible/ansible/blob/af35983/lib/ansible/modules/packaging/os/yum.py#L1394

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

yum

ANSIBLE VERSION
devel
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Apr 13, 2018

cc @Akasurde @berenddeschouwer @kustodian @verm666
click here for bot help

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Apr 13, 2018
@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Apr 13, 2018
@mkrizek mkrizek added this to READY TO REVIEW in CEM Apr 13, 2018
Akasurde
Akasurde approved these changes Apr 14, 2018
View reviewed changes
Copy link
Member

@Akasurde Akasurde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed core_review In order to be merged, this PR must follow the core review workflow. labels Apr 14, 2018
@kustodian
Copy link
Contributor

shipit

1 similar comment
@resmo
Copy link
Contributor

resmo commented Apr 15, 2018

shipit

@Akasurde Akasurde merged commit 1ff5e97 into ansible:devel Apr 16, 2018
@Akasurde
Copy link
Member

@kustodian @resmo thanks for the review.

@mkrizek mkrizek deleted the yum-docs-name-not-required branch April 16, 2018 08:37
@mkrizek mkrizek moved this from READY TO REVIEW to DONE in CEM Apr 16, 2018
@mkrizek mkrizek mentioned this pull request May 17, 2018
Closed
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
@mkrizek @ilicmilan
yum: docs: name is not required (ansible#38758)
4a96652
@dagwieers dagwieers added the packaging Packaging category label Mar 3, 2019
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@resmo resmo resmo approved these changes

@Akasurde Akasurde Akasurde approved these changes

@maxamillion maxamillion Awaiting requested review from maxamillion

Assignees
No one assigned
Labels
docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. owner_pr This PR is made by the module's maintainer. packaging Packaging category shipit This PR is ready to be merged by Core support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
No open projects
CEM
DONE
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mkrizek @ansibot @kustodian @resmo @Akasurde @dagwieers