Add supported connection in junos module documentation #38813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add supported connection type in junos module doucmentation.
ansibot
added
core_review
ganeshrn
removed
the
needs_triage
gundalow
approved these changes
Apr 16, 2018
gundalow
reviewed
Apr 16, 2018
| @@ -81,6 +81,7 @@ | |||
| - This module requires the netconf system service be enabled on | |||
| the remote device being managed. | |||
| - Tested against vSRX JUNOS version 15.1X49-D15.4, vqfx-10000 JUNOS Version 15.1X53-D60.4. | |||
| - Works with local connection type only. | |||
There was a problem hiding this comment.
What's the plan for this, since it's connection local only
There was a problem hiding this comment.
Since these modules will use junos-eznc library and not the persistent connection framework it will continue to be supported with connection=local
In future, we might want to move these modules to a role within ansible-network.
gundalow
reviewed
Apr 16, 2018
| @@ -54,6 +54,7 @@ | |||
| - This module requires the netconf system service be enabled on | |||
| the remote device being managed. | |||
| - Tested against vMX JUNOS version 17.3R1.10. | |||
| - Works with local connection type only. | |||
There was a problem hiding this comment.
What's the plan for this, since it's connection local only
|
The test The test The test The test The test The test The test The test |
ansibot
added
needs_revision
|
When there are lots of errors I'd suggest starting with the errors from |
|
The test The test The test The test The test The test The test The test |
|
The test The test The test The test The test The test The test The test |
|
Phew. Some day I need to figure out how to break lines within the YAML, but for now two lines will be fine. Sorry about all the error output. |
ansibot
added
core_review
acozine
approved these changes
Apr 17, 2018
ganeshrn
added a commit
to ganeshrn/ansible
that referenced
this pull request
Apr 17, 2018
* Add supported connection in junos module documentation Add supported connection type in junos module doucmentation. * adds link to platform docs * makes recommended connection a code snippet * does this fix banner and command? * does this fix the rest of the errors? (cherry picked from commit 67d561b)
ganeshrn
added a commit
that referenced
this pull request
Apr 17, 2018
* Add supported connection in junos module documentation Add supported connection type in junos module doucmentation. * adds link to platform docs * makes recommended connection a code snippet * does this fix banner and command? * does this fix the rest of the errors? (cherry picked from commit 67d561b)
|
Cherry-pick to 2.5 8f2d46e |
ilicmilan
pushed a commit
to ilicmilan/ansible
that referenced
this pull request
Nov 7, 2018
* Add supported connection in junos module documentation Add supported connection type in junos module doucmentation. * adds link to platform docs * makes recommended connection a code snippet * does this fix banner and command? * does this fix the rest of the errors?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Add supported connection type in junos module doucmentation.
ISSUE TYPE
COMPONENT NAME
junos_*
ANSIBLE VERSION
ADDITIONAL INFORMATION