Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keep track of original inventory hostname in play context #38818

Merged
merged 3 commits into from Apr 16, 2018
Merged

keep track of original inventory hostname in play context #38818

merged 3 commits into from Apr 16, 2018

Conversation

jctanner
Copy link
Contributor

@jctanner jctanner commented Apr 16, 2018 •
edited

This change further enables the https://github.com/jctanner/ansible-vcr project to collect fixtures per host in
situations where the host context is totally lost due to delegation.

SUMMARY

This change further enables the ansible-vcr project to collect fixtures per host in
situations where the host context is totally lost due to delegation.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

task_executor

ANSIBLE VERSION
2.6

@jctanner
surface the original inventory hostname prior to delegation to the pl…
5e301f3 
…ay context.

this change further enables the ansible-vcr project to collect fixtures per host in
situations where the host context is totally lost due to delegation.
@ansibot ansibot added feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 16, 2018
@jctanner jctanner requested review from bcoca and abadger April 16, 2018 17:05
@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Apr 16, 2018
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Apr 16, 2018
@bcoca bcoca merged commit 068b9ac into ansible:devel Apr 16, 2018
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
@jctanner @ilicmilan
keep track of original inventory hostname in play context (ansible#38818
ba84bc0 
)

this change further enables the ansible-vcr project to collect fixtures per host in
situations where the host context is totally lost due to delegation.

* Keep some original pre-delegate values in connection options
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bcoca bcoca Awaiting requested review from bcoca

@abadger abadger Awaiting requested review from abadger

Assignees
No one assigned
Labels
feature This issue/PR relates to a feature request. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jctanner @bcoca @ansibot