Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace the aliases ref target by plugin type #38925

Merged
merged 1 commit into from
May 30, 2018

Conversation

abadger
Copy link
Contributor

@abadger abadger commented Apr 18, 2018

SUMMARY

Aliases for plugins need to be namespaced in the same way as the canonical plugin name.

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
COMPONENT NAME

module and plugin docs

ANSIBLE VERSION
devel 2.5

@ansibot
Copy link
Contributor

ansibot commented Apr 18, 2018

@ansibot ansibot added bug This issue/PR relates to a bug. docs This issue/PR relates to or includes documentation. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Apr 18, 2018
@gundalow
Copy link
Contributor

Can we update the M(...) link in here as well please?

@gundalow gundalow removed the needs_triage Needs a first human triage before being processed. label Apr 18, 2018
@abadger
Copy link
Contributor Author

abadger commented Apr 19, 2018

M() updated in a separate PR which is now merged.

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 27, 2018
@ansibot ansibot added the affects_2.6 This issue/PR affects Ansible v2.6 label May 21, 2018
@maxamillion
Copy link
Contributor

rebuild_merge

@ansibot ansibot added stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. and removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels May 28, 2018
@ansibot ansibot merged commit 7ce1afe into ansible:devel May 30, 2018
acozine pushed a commit to acozine/ansible that referenced this pull request Jun 4, 2018
nitzmahone pushed a commit that referenced this pull request Jun 6, 2018
* Fix formatting error in rst plugin template (#38956)

The hyperlink syntax used is wrong and the resulting
rendered documents have broken links.

(cherry picked from commit aaf2ff6)

* Add missing > to fix 'edit this document' link (#39067)

(cherry picked from commit ebdf6d0)

* Fix problems in documentation generation (#40050)

* Treat C(...) as inline literal (as opposed to interpreted text).

* Making test for true and false more precise, to avoid matching 1, 1.0, etc.

* The 'is sameas' test already takes care of definedness.

(cherry picked from commit f169334)

* Namespace the aliases ref target by plugin type (#38925)

(cherry picked from commit 7ce1afe)

* Use colspan on td instead of divs for hierarchical tables (#39948)

Address Firefox table-rendering issues in docs. Refactor to use colspan to provide table cells which can vary in width and indentation; the outermost has the greatest colspan, and each nested key has a colspan of one less than the parent, with padding cells for indentation.
Apply styling to table cells to get the table height to work without hacks or browser-specific
styling.  Simplify the markup and CSS by removing extra divs. Use two passes over the options, return values, and return facts in the Jinja2 module-docs template: one to determine the maximum nesting depth to compute the maximum colspan needed, plus one to lay out the rows.
(cherry picked from commit fa5c028)
jacum pushed a commit to jacum/ansible that referenced this pull request Jun 26, 2018
@ansible ansible locked and limited conversation to collaborators May 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.6 This issue/PR affects Ansible v2.6 bug This issue/PR relates to a bug. docs This issue/PR relates to or includes documentation. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants