Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ovirt: Use id instead of name of Blank template #38948

Merged
merged 1 commit into from Apr 18, 2018
Merged

ovirt: Use id instead of name of Blank template #38948

merged 1 commit into from Apr 18, 2018

Conversation

machacekondra
Copy link
Contributor

SUMMARY

Since Blank template could be renamed we must use it's ID to be sure we
are using the Blank template.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ovirt_vms

ANSIBLE VERSION
2.5
ADDITIONAL INFORMATION

@machacekondra
ovirt: Use id instead of name of Blank template
bce301e 
Since Blank template could be renamed we must use it's ID to be sure we
are using the Blank template.
@ansibot
Copy link
Contributor

ansibot commented Apr 18, 2018

cc @mwperina
click here for bot help

@ansibot ansibot added bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. virt Virt community (incl. QEMU, KVM, libvirt, ovirt, RHV and Proxmox) owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community. labels Apr 18, 2018
mwperina
mwperina approved these changes Apr 18, 2018
View reviewed changes
Copy link
Contributor

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot added automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. labels Apr 18, 2018
@ansibot ansibot merged commit aeaf0e3 into ansible:devel Apr 18, 2018
@machacekondra machacekondra deleted the fix_blank_template_spec branch August 15, 2018 10:43
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
@machacekondra @ilicmilan
ovirt: Use id instead of name of Blank template (ansible#38948)
1114f40 
Since Blank template could be renamed we must use it's ID to be sure we
are using the Blank template.
@dagwieers dagwieers added ovirt oVirt and RHV community and removed virt Virt community (incl. QEMU, KVM, libvirt, ovirt, RHV and Proxmox) labels Feb 21, 2019
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mwperina mwperina mwperina approved these changes

Assignees
No one assigned
Labels
automerge This PR was automatically merged by ansibot. bug This issue/PR relates to a bug. cloud module This issue/PR relates to a module. ovirt oVirt and RHV community owner_pr This PR is made by the module's maintainer. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@machacekondra @ansibot @mwperina @dagwieers