Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken yaml callback/sumologic.py #38966

Merged
merged 1 commit into from
Apr 18, 2018
Merged

Fix broken yaml callback/sumologic.py #38966

merged 1 commit into from
Apr 18, 2018

Conversation

gundalow
Copy link
Contributor

SUMMARY

Previously this was causing a backtrace in plugin_formattter.py

Should be backported into older branches

ISSUE TYPE
  • Docs Pull Request

@ansibot
Copy link
Contributor

ansibot commented Apr 18, 2018

cc @ryancurrah
click here for bot help

@ansibot ansibot added docs This issue/PR relates to or includes documentation. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 18, 2018
@gundalow gundalow removed the needs_triage Needs a first human triage before being processed. label Apr 18, 2018
@gundalow gundalow merged commit c1ae1c8 into ansible:devel Apr 18, 2018
@gundalow gundalow deleted the doc-sumologic branch April 18, 2018 19:54
@ryancurrah
Copy link
Contributor

Thank you I didn't realize that format would break yaml

@gundalow
Copy link
Contributor Author

Most welcome. Turns out we don't detect this in CI. I've made a note to look into that,

New callback in 2.6, so no need to backport.

ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
@gundalow @ilicmilan
Fix broken yaml (ansible#38966)
3fb72e2
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
docs This issue/PR relates to or includes documentation. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gundalow @ansibot @ryancurrah