Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix interface method change #38996

Merged
merged 1 commit into from
Apr 19, 2018
Merged

Fix interface method change #38996

merged 1 commit into from
Apr 19, 2018

Conversation

obourdon
Copy link
Contributor

@obourdon obourdon commented Apr 19, 2018 •
edited

SUMMARY

Fixes #38692

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

interfaces_file

ANSIBLE VERSION
ansible 2.6.0 (work e2aa1155ba) last updated 2018/04/19 09:51:12 (GMT +200)
  config file = None
  configured module search path = [u'/Users/olivierbourdon/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /Users/olivierbourdon/Documents/WORK/OpenNext/TECH/CODE/ANSIBLE/0-REF-ansible/lib/ansible
  executable location = /Users/olivierbourdon/Documents/WORK/OpenNext/TECH/CODE/ANSIBLE/0-REF-ansible/bin/ansible
  python version = 2.7.14 (default, Sep 22 2017, 00:06:07) [GCC 4.2.1 Compatible Apple LLVM 8.1.0 (clang-802.0.42)]
ADDITIONAL INFORMATION

Before:

iface eth0 inet dhcp
    address 192.168.178.111
    netmask 255.255.255.0
   method static

After:

iface eth0 inet static
    address 192.168.178.111
    netmask 255.255.255.0

@obourdon obourdon mentioned this pull request Apr 19, 2018
Merged
@ansibot
Copy link
Contributor

ansibot commented Apr 19, 2018

cc @hryamzik
click here for bot help

@ansibot ansibot added bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community. labels Apr 19, 2018
@obourdon obourdon mentioned this pull request Apr 19, 2018
Closed
@hryamzik
Copy link
Contributor

@obourdon great, thanks! Can I also ask you to add related tests?

@ansibot
Copy link
Contributor

ansibot commented Apr 19, 2018

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/system/interfaces_file.py:308:34: E231 missing whitespace after ','

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. labels Apr 19, 2018
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. owner_pr This PR is made by the module's maintainer. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 19, 2018
@obourdon
Copy link
Contributor Author

@hryamzik please review, thanks

@hryamzik
Copy link
Contributor

LGTM

Except I'd love to see tests for this case.

@ansibot ansibot added automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. labels Apr 19, 2018
@ansibot ansibot merged commit 87a07e8 into ansible:devel Apr 19, 2018
@obourdon
Copy link
Contributor Author

@hryamzik oops deeply sorry about forgetting the tests, will add them in another PR as this one seems to have been merged already

@obourdon obourdon deleted the fix-itf-method-change branch April 19, 2018 13:01
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 14, 2018
@obourdon
Fix interface method change (ansible#38996)
bf673aa
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 15, 2018
@obourdon
Fix interface method change (ansible#38996)
60f25e0
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
@obourdon @ilicmilan
Fix interface method change (ansible#38996)
d3ae6ee
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
automerge This PR was automatically merged by ansibot. bug This issue/PR relates to a bug. module This issue/PR relates to a module. owner_pr This PR is made by the module's maintainer. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

interfaces_file changing method is not possible
3 participants
@obourdon @ansibot @hryamzik