Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apt: fix build-dep idempotency #38999

Merged
merged 1 commit into from Apr 20, 2018
Merged

apt: fix build-dep idempotency #38999

merged 1 commit into from Apr 20, 2018

Conversation

mkrizek
Copy link
Contributor

@mkrizek mkrizek commented Apr 19, 2018

SUMMARY

Fixes #38995

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

apt

ANSIBLE VERSION
devel
ADDITIONAL INFORMATION

@mkrizek mkrizek requested review from resmo and Akasurde April 19, 2018 08:35
@mkrizek mkrizek added this to READY TO REVIEW in CEM Apr 19, 2018
@ansibot
Copy link
Contributor

ansibot commented Apr 19, 2018

cc @mgwilliams
click here for bot help

@ansibot ansibot added bug This issue/PR relates to a bug. module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Apr 19, 2018
@mkrizek mkrizek force-pushed the 38995-apt-build-dep-idempotency branch from d80e021 to 257c0a8 Compare April 19, 2018 11:06
@mkrizek mkrizek force-pushed the 38995-apt-build-dep-idempotency branch from 257c0a8 to 4999f4b Compare April 19, 2018 11:06
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 19, 2018
resmo
resmo approved these changes Apr 19, 2018
View reviewed changes
Copy link
Contributor

@resmo resmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. labels Apr 19, 2018
Akasurde
Akasurde approved these changes Apr 20, 2018
View reviewed changes
Copy link
Member

@Akasurde Akasurde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@resmo resmo merged commit 62d2df7 into ansible:devel Apr 20, 2018
@mkrizek mkrizek deleted the 38995-apt-build-dep-idempotency branch April 20, 2018 06:33
@mkrizek
Copy link
Contributor Author

mkrizek commented Apr 20, 2018

Thanks @resmo @Akasurde!

@mkrizek mkrizek moved this from READY TO REVIEW to DONE in CEM Apr 20, 2018
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 14, 2018
@mkrizek
apt: fix build-dep idempotency (ansible#38999)
bce6b13
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 15, 2018
@mkrizek
apt: fix build-dep idempotency (ansible#38999)
79680ed
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
@mkrizek @ilicmilan
apt: fix build-dep idempotency (ansible#38999)
3bf34d1
@dagwieers dagwieers added the packaging Packaging category label Mar 3, 2019
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@resmo resmo resmo approved these changes

@Akasurde Akasurde Akasurde approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug. module This issue/PR relates to a module. packaging Packaging category shipit This PR is ready to be merged by Core support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
No open projects
CEM
DONE
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Module apt with state=build-dep reports change even when there is none
5 participants
@mkrizek @ansibot @resmo @Akasurde @dagwieers