Internal refs #39094
Merged
Internal refs #39094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acozine
added this to Docsite work
in Ansible-maintained Collections Documentation
via automation
dharmabumstead
approved these changes
Apr 20, 2018
ansibot
added
aci
gundalow
approved these changes
Apr 20, 2018
|
Feel free to merge once Shippable is green |
ansibot
added
needs_rebase
mattclay
requested changes
Apr 20, 2018
| @@ -171,7 +172,7 @@ Include it in your module file like this: | |||
|
|
|||
| #!/usr/bin/python | |||
| # Copyright (c) 2017 [REPLACE THIS] | |||
| # GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt) | |||
| # GNU General Public License v3.0+ (see COPYING or `the license itself <https://www.gnu.org/licenses/gpl-3.0.txt>`_) | |||
There was a problem hiding this comment.
I don't think there should be markup in this and the other code blocks.
ansibot
removed
the
needs_rebase
mattclay
approved these changes
Apr 20, 2018
Ansible-maintained Collections Documentation
automation
moved this from Docsite work
to Done
Apr 20, 2018
acozine
moved this from Done
to Backport to 2.5
in Ansible-maintained Collections Documentation
acozine
pushed a commit
to acozine/ansible
that referenced
this pull request
Apr 23, 2018
* fixes community refs * fixes appendix refs * fixes scenario refs, keeps ACI guide link to devel * fixes windows refs * fixes user guide refs * fixes dev guide refs (cherry picked from commit bbfd6c6)
acozine
moved this from Backport to 2.5
to Done
in Ansible-maintained Collections Documentation
dagwieers
reviewed
Apr 23, 2018
| @@ -65,7 +65,7 @@ For instance ensuring that a specific tenant exists, is done using the following | |||
| description: Customer XYZ | |||
| state: present | |||
|
|
|||
| A complete list of existing ACI modules is available for `the latest stable release <http://docs.ansible.com/ansible/latest/modules/list_of_network_modules.html#aci>`_ as well as `the current development version <http://docs.ansible.com/ansible/devel/modules/list_of_network_modules.html#aci>`_. | |||
| A complete list of existing ACI modules is available for the latest stable release on the :ref:`list of network modules <list_of_network_modules>`. You can also view the `current development version <http://docs.ansible.com/ansible/devel/modules/list_of_network_modules.html#aci>`_. | |||
There was a problem hiding this comment.
The problem with doing this is that it will not link to the latest stable when you're looking at the devel docs. You are in fact looking at the same link as the devel module list.
So this is incorrect :-/
abadger
pushed a commit
that referenced
this pull request
Apr 23, 2018
* fixes community refs * fixes appendix refs * fixes scenario refs, keeps ACI guide link to devel * fixes windows refs * fixes user guide refs * fixes dev guide refs (cherry picked from commit bbfd6c6)
oolongbrothers
pushed a commit
to oolongbrothers/ansible
that referenced
this pull request
May 14, 2018
* fixes community refs * fixes appendix refs * fixes scenario refs, keeps ACI guide link to devel * fixes windows refs * fixes user guide refs * fixes dev guide refs
oolongbrothers
pushed a commit
to oolongbrothers/ansible
that referenced
this pull request
May 15, 2018
* fixes community refs * fixes appendix refs * fixes scenario refs, keeps ACI guide link to devel * fixes windows refs * fixes user guide refs * fixes dev guide refs
ilicmilan
pushed a commit
to ilicmilan/ansible
that referenced
this pull request
Nov 7, 2018
* fixes community refs * fixes appendix refs * fixes scenario refs, keeps ACI guide link to devel * fixes windows refs * fixes user guide refs * fixes dev guide refs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes internal references in the docs, using anchors wherever possible.
Gets rid of old http links to docs.ansible.com, except for:
develversion of the docsISSUE TYPE
COMPONENT NAME
docs.ansible.com
ANSIBLE VERSION
2.5
ADDITIONAL INFORMATION
Part of the grand cleanup, related to #39030