Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP 8 naming convention violation in EC2 dynamic inventory #39164

Merged
merged 1 commit into from Apr 23, 2018
Merged

PEP 8 naming convention violation in EC2 dynamic inventory #39164

merged 1 commit into from Apr 23, 2018

Conversation

javierbeaumont
Copy link
Contributor

@javierbeaumont javierbeaumont commented Apr 23, 2018 •
edited

SUMMARY

PEP 8 naming convention violation: Variable in function should be lowercase.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

EC2 Dynamic Inventory

@ansibot
Copy link
Contributor

ansibot commented Apr 23, 2018

cc @ryansb @s-hertel @willthames
click here for bot help

@ansibot ansibot added aws bug This issue/PR relates to a bug. c:inventory/contrib_script cloud inventory Inventory category needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. support:community This issue/PR relates to code supported by the Ansible community. labels Apr 23, 2018
@ryansb ryansb merged commit 8faf983 into ansible:devel Apr 23, 2018
@javierbeaumont javierbeaumont deleted the pep8_naming_convention branch April 23, 2018 16:28
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Apr 26, 2018
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 14, 2018
@javierbeaumont
[cloud][aws] PEP8 renaming in EC2 dynamic inventory (ansible#39164)
9aa597a
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request May 15, 2018
@javierbeaumont
[cloud][aws] PEP8 renaming in EC2 dynamic inventory (ansible#39164)
802cba7
ilicmilan pushed a commit to ilicmilan/ansible that referenced this pull request Nov 7, 2018
@javierbeaumont @ilicmilan
[cloud][aws] PEP8 renaming in EC2 dynamic inventory (ansible#39164)
6e72697
@ansible ansible locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryansb ryansb ryansb approved these changes

Assignees
No one assigned
Labels
aws bug This issue/PR relates to a bug. c:inventory/contrib_script cloud inventory Inventory category new_contributor This PR is the first contribution by a new community member. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@javierbeaumont @ansibot @ryansb @samdoran